Apache
/
druid
mirror of https://github.com/apache/druid.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Fix CuratorModule flaky test (#8562) 

For CuratorModuleTest. exitsJvmWhenMaxRetriesExceeded(), the expected
log message is intermittently not the first one in the list of captured
log messages. For example, it is the second one in
https://travis-ci.org/apache/incubator-druid/jobs/586792178#L754.
This commit is contained in:
Chi Cao Minh 2019-09-20 13:36:22 -07:00 committed by Fangjin Yang
parent 62afbca7b9
commit 187b507b3d
1 changed files with 10 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
server/src/test/java/org/apache/druid/curator/CuratorModuleTest.java
View File

@ -147,11 +147,16 @@ public final class CuratorModuleTest
// org.apache.curator.framework.impl.CuratorFrameworkImpl logs "Background retry gave up" unhandled error twice
List<LogEvent> loggingEvents = logger.getLogEvents();
Assert.assertFalse(loggingEvents.isEmpty());
LogEvent logEvent = loggingEvents.get(0);
String message = "Logging events: " + loggingEvents;
Assert.assertEquals(message, Level.ERROR, logEvent.getLevel());
Assert.assertEquals(message, "Unhandled error in Curator Framework", logEvent.getMessage().getFormattedMessage());
Assert.assertTrue(
"Logging events: " + loggingEvents,
loggingEvents.stream()
.anyMatch(l ->
l.getLevel().equals(Level.ERROR)
&& l.getMessage()
.getFormattedMessage()
.equals("Unhandled error in Curator Framework")
)
);
}
@Ignore("Verifies changes in https://github.com/apache/incubator-druid/pull/8458, but overkill for regular testing")