Fix compilation error for MSQCompactionRunnerTest (#17516)

This commit is contained in:
Vishesh Garg 2024-11-27 17:16:30 +05:30 committed by GitHub
parent 80d6763e39
commit 1b9a6dde9f
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 2 additions and 16 deletions

View File

@ -149,7 +149,6 @@ public class MSQCompactionRunnerTest
null, null,
Collections.emptyMap(), Collections.emptyMap(),
null, null,
null,
null null
); );
CompactionConfigValidationResult validationResult = MSQ_COMPACTION_RUNNER.validateCompactionTask( CompactionConfigValidationResult validationResult = MSQ_COMPACTION_RUNNER.validateCompactionTask(
@ -171,7 +170,6 @@ public class MSQCompactionRunnerTest
null, null,
Collections.emptyMap(), Collections.emptyMap(),
null, null,
null,
null null
); );
Assert.assertFalse(MSQ_COMPACTION_RUNNER.validateCompactionTask(compactionTask, INTERVAL_DATASCHEMAS).isValid()); Assert.assertFalse(MSQ_COMPACTION_RUNNER.validateCompactionTask(compactionTask, INTERVAL_DATASCHEMAS).isValid());
@ -185,7 +183,6 @@ public class MSQCompactionRunnerTest
null, null,
Collections.emptyMap(), Collections.emptyMap(),
null, null,
null,
null null
); );
Assert.assertTrue(MSQ_COMPACTION_RUNNER.validateCompactionTask(compactionTask, INTERVAL_DATASCHEMAS).isValid()); Assert.assertTrue(MSQ_COMPACTION_RUNNER.validateCompactionTask(compactionTask, INTERVAL_DATASCHEMAS).isValid());
@ -200,7 +197,6 @@ public class MSQCompactionRunnerTest
null, null,
Collections.emptyMap(), Collections.emptyMap(),
null, null,
null,
null null
); );
@ -223,7 +219,6 @@ public class MSQCompactionRunnerTest
null, null,
Collections.emptyMap(), Collections.emptyMap(),
null, null,
null,
null null
); );
@ -245,7 +240,6 @@ public class MSQCompactionRunnerTest
null, null,
Collections.emptyMap(), Collections.emptyMap(),
null, null,
null,
null null
); );
Assert.assertFalse(MSQ_COMPACTION_RUNNER.validateCompactionTask(compactionTask, INTERVAL_DATASCHEMAS).isValid()); Assert.assertFalse(MSQ_COMPACTION_RUNNER.validateCompactionTask(compactionTask, INTERVAL_DATASCHEMAS).isValid());
@ -259,7 +253,6 @@ public class MSQCompactionRunnerTest
null, null,
Collections.emptyMap(), Collections.emptyMap(),
null, null,
null,
null null
); );
Assert.assertTrue(MSQ_COMPACTION_RUNNER.validateCompactionTask(compactionTask, INTERVAL_DATASCHEMAS).isValid()); Assert.assertTrue(MSQ_COMPACTION_RUNNER.validateCompactionTask(compactionTask, INTERVAL_DATASCHEMAS).isValid());
@ -273,7 +266,6 @@ public class MSQCompactionRunnerTest
null, null,
Collections.emptyMap(), Collections.emptyMap(),
new ClientCompactionTaskGranularitySpec(null, Granularities.ALL, null), new ClientCompactionTaskGranularitySpec(null, Granularities.ALL, null),
null,
null null
); );
Assert.assertTrue(MSQ_COMPACTION_RUNNER.validateCompactionTask(compactionTask, INTERVAL_DATASCHEMAS).isValid()); Assert.assertTrue(MSQ_COMPACTION_RUNNER.validateCompactionTask(compactionTask, INTERVAL_DATASCHEMAS).isValid());
@ -287,7 +279,6 @@ public class MSQCompactionRunnerTest
null, null,
Collections.emptyMap(), Collections.emptyMap(),
new ClientCompactionTaskGranularitySpec(null, null, false), new ClientCompactionTaskGranularitySpec(null, null, false),
null,
AGGREGATORS.toArray(new AggregatorFactory[0]) AGGREGATORS.toArray(new AggregatorFactory[0])
); );
Assert.assertFalse(MSQ_COMPACTION_RUNNER.validateCompactionTask(compactionTask, INTERVAL_DATASCHEMAS).isValid()); Assert.assertFalse(MSQ_COMPACTION_RUNNER.validateCompactionTask(compactionTask, INTERVAL_DATASCHEMAS).isValid());
@ -301,7 +292,6 @@ public class MSQCompactionRunnerTest
null, null,
Collections.emptyMap(), Collections.emptyMap(),
new ClientCompactionTaskGranularitySpec(null, null, true), new ClientCompactionTaskGranularitySpec(null, null, true),
null,
null null
); );
Assert.assertFalse(MSQ_COMPACTION_RUNNER.validateCompactionTask(compactionTask, INTERVAL_DATASCHEMAS).isValid()); Assert.assertFalse(MSQ_COMPACTION_RUNNER.validateCompactionTask(compactionTask, INTERVAL_DATASCHEMAS).isValid());
@ -318,7 +308,6 @@ public class MSQCompactionRunnerTest
null, null,
Collections.emptyMap(), Collections.emptyMap(),
new ClientCompactionTaskGranularitySpec(null, null, true), new ClientCompactionTaskGranularitySpec(null, null, true),
null,
new AggregatorFactory[]{new LongSumAggregatorFactory(outputColName, inputColName)} new AggregatorFactory[]{new LongSumAggregatorFactory(outputColName, inputColName)}
); );
CompactionConfigValidationResult validationResult = MSQ_COMPACTION_RUNNER.validateCompactionTask( CompactionConfigValidationResult validationResult = MSQ_COMPACTION_RUNNER.validateCompactionTask(
@ -335,7 +324,7 @@ public class MSQCompactionRunnerTest
@Test @Test
public void testRunCompactionTasksWithEmptyTaskListFails() throws Exception public void testRunCompactionTasksWithEmptyTaskListFails() throws Exception
{ {
CompactionTask compactionTask = createCompactionTask(null, null, Collections.emptyMap(), null, null, null); CompactionTask compactionTask = createCompactionTask(null, null, Collections.emptyMap(), null, null);
TaskStatus taskStatus = MSQ_COMPACTION_RUNNER.runCompactionTasks(compactionTask, Collections.emptyMap(), null); TaskStatus taskStatus = MSQ_COMPACTION_RUNNER.runCompactionTasks(compactionTask, Collections.emptyMap(), null);
Assert.assertTrue(taskStatus.isFailure()); Assert.assertTrue(taskStatus.isFailure());
} }
@ -350,7 +339,6 @@ public class MSQCompactionRunnerTest
dimFilter, dimFilter,
Collections.emptyMap(), Collections.emptyMap(),
null, null,
null,
null null
); );
@ -481,7 +469,6 @@ public class MSQCompactionRunnerTest
dimFilter, dimFilter,
Collections.emptyMap(), Collections.emptyMap(),
null, null,
null,
null null
); );
@ -561,7 +548,6 @@ public class MSQCompactionRunnerTest
@Nullable DimFilter dimFilter, @Nullable DimFilter dimFilter,
Map<String, Object> contextParams, Map<String, Object> contextParams,
@Nullable ClientCompactionTaskGranularitySpec granularitySpec, @Nullable ClientCompactionTaskGranularitySpec granularitySpec,
@Nullable List<DimensionSchema> dimensionSchemas,
@Nullable AggregatorFactory[] metricsSpec @Nullable AggregatorFactory[] metricsSpec
) )
{ {
@ -585,7 +571,7 @@ public class MSQCompactionRunnerTest
)) ))
.transformSpec(transformSpec) .transformSpec(transformSpec)
.granularitySpec(granularitySpec) .granularitySpec(granularitySpec)
.dimensionsSpec(new DimensionsSpec(dimensionSchemas)) .dimensionsSpec(new DimensionsSpec(null))
.metricsSpec(metricsSpec) .metricsSpec(metricsSpec)
.compactionRunner(MSQ_COMPACTION_RUNNER) .compactionRunner(MSQ_COMPACTION_RUNNER)
.context(context); .context(context);