Apache
/
druid
mirror of https://github.com/apache/druid.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Workaround for non-thread-safe use of CardinalityAggregator. (#4304)

This commit is contained in:
Gian Merlino 2017-05-23 10:33:03 +09:00 committed by GitHub
parent e043bf88ec
commit 22e5f52d00
2 changed files with 5 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
processing/src/main/java/io/druid/query/aggregation/cardinality/CardinalityAggregator.java
View File

@ -109,7 +109,9 @@ public class CardinalityAggregator implements Aggregator
@Override @Override
public Object get() public Object get()
{ {
return collector; // Workaround for non-thread-safe use of HyperLogLogCollector.
// OnheapIncrementalIndex has a penchant for calling "aggregate" and "get" simultaneously.
return HyperLogLogCollector.makeCollectorSharingStorage(collector);
} }
@Override @Override

3
processing/src/main/java/io/druid/query/aggregation/hyperloglog/HyperUniquesAggregator.java
View File

@ -55,7 +55,8 @@ public class HyperUniquesAggregator implements Aggregator
@Override @Override
public Object get() public Object get()
{ {
// Workaround for OnheapIncrementalIndex's penchant for calling "aggregate" and "get" simultaneously. // Workaround for non-thread-safe use of HyperLogLogCollector.
// OnheapIncrementalIndex has a penchant for calling "aggregate" and "get" simultaneously.
return HyperLogLogCollector.makeCollectorSharingStorage(collector); return HyperLogLogCollector.makeCollectorSharingStorage(collector);
} }