From 235ecce522346e14042fa4fbe56791c1070a2b66 Mon Sep 17 00:00:00 2001 From: Dhruv Parthasarathy Date: Wed, 26 Jun 2013 15:12:55 -0700 Subject: [PATCH] fixed constants and made them static finals --- .../src/main/java/druid/examples/webStream/UpdateStream.java | 3 ++- .../main/java/druid/examples/webStream/WebFirehoseFactory.java | 3 ++- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/examples/src/main/java/druid/examples/webStream/UpdateStream.java b/examples/src/main/java/druid/examples/webStream/UpdateStream.java index a266fd37f01..c22e44ec83f 100644 --- a/examples/src/main/java/druid/examples/webStream/UpdateStream.java +++ b/examples/src/main/java/druid/examples/webStream/UpdateStream.java @@ -24,6 +24,7 @@ public class UpdateStream implements Runnable private BlockingQueue> queue; private ObjectMapper mapper; private final TypeReference> typeRef; + private static final long queueWaitTime = 15L; public UpdateStream(InputSupplier supplier, BlockingQueue> queue) { @@ -49,7 +50,7 @@ public class UpdateStream implements Runnable if (isValid(line)) { try { HashMap map = mapper.readValue(line, typeRef); - queue.offer(map, 15L, TimeUnit.SECONDS); + queue.offer(map, queueWaitTime, TimeUnit.SECONDS); log.info("Successfully added to queue"); } catch (JsonParseException e) { diff --git a/examples/src/main/java/druid/examples/webStream/WebFirehoseFactory.java b/examples/src/main/java/druid/examples/webStream/WebFirehoseFactory.java index 843679956e4..c18a13e4a2c 100644 --- a/examples/src/main/java/druid/examples/webStream/WebFirehoseFactory.java +++ b/examples/src/main/java/druid/examples/webStream/WebFirehoseFactory.java @@ -27,6 +27,8 @@ public class WebFirehoseFactory implements FirehoseFactory private final List dimensions; private final String timeDimension; private final List renamedDimensions; + private static final int QUEUE_SIZE = 2000; + @JsonCreator public WebFirehoseFactory( @@ -45,7 +47,6 @@ public class WebFirehoseFactory implements FirehoseFactory @Override public Firehose connect() throws IOException { - final int QUEUE_SIZE = 2000; final BlockingQueue> queue = new ArrayBlockingQueue>(QUEUE_SIZE); Runnable updateStream = new UpdateStream(new WebJsonSupplier(dimensions, url), queue);