From a4003966b23c5c1f6b0f48e6b4f23ab68d290118 Mon Sep 17 00:00:00 2001
From: nishantmonu51 <nishant.monu51@gmail.com>
Date: Fri, 20 Jun 2014 21:45:30 +0530
Subject: [PATCH] push sinks after bootstrap. fix #570

---
 .../realtime/plumber/RealtimePlumber.java     | 69 +++++++++++--------
 1 file changed, 40 insertions(+), 29 deletions(-)

diff --git a/server/src/main/java/io/druid/segment/realtime/plumber/RealtimePlumber.java b/server/src/main/java/io/druid/segment/realtime/plumber/RealtimePlumber.java
index 306350aaaa3..4f3b3c17587 100644
--- a/server/src/main/java/io/druid/segment/realtime/plumber/RealtimePlumber.java
+++ b/server/src/main/java/io/druid/segment/realtime/plumber/RealtimePlumber.java
@@ -152,6 +152,8 @@ public class RealtimePlumber implements Plumber
     bootstrapSinksFromDisk();
     registerServerViewCallback();
     startPersistThread();
+    // Push pending sinks bootstrapped from previous run
+    mergeAndPush();
   }
 
   @Override
@@ -595,35 +597,7 @@ public class RealtimePlumber implements Plumber
                   return ScheduledExecutors.Signal.STOP;
                 }
 
-                log.info("Starting merge and push.");
-
-                DateTime minTimestampAsDate = segmentGranularity.truncate(
-                    rejectionPolicy.getCurrMaxTime().minus(windowMillis)
-                );
-                long minTimestamp = minTimestampAsDate.getMillis();
-
-                log.info("Found [%,d] sinks. minTimestamp [%s]", sinks.size(), minTimestampAsDate);
-
-                List<Map.Entry<Long, Sink>> sinksToPush = Lists.newArrayList();
-                for (Map.Entry<Long, Sink> entry : sinks.entrySet()) {
-                  final Long intervalStart = entry.getKey();
-                  if (intervalStart < minTimestamp) {
-                    log.info("Adding entry[%s] for merge and push.", entry);
-                    sinksToPush.add(entry);
-                  } else {
-                    log.warn(
-                        "[%s] < [%s] Skipping persist and merge.",
-                        new DateTime(intervalStart),
-                        minTimestampAsDate
-                    );
-                  }
-                }
-
-                log.info("Found [%,d] sinks to persist and merge", sinksToPush.size());
-
-                for (final Map.Entry<Long, Sink> entry : sinksToPush) {
-                  persistAndMerge(entry.getKey(), entry.getValue());
-                }
+                mergeAndPush();
 
                 if (stopped) {
                   log.info("Stopping merge-n-push overseer thread");
@@ -636,6 +610,43 @@ public class RealtimePlumber implements Plumber
         );
   }
 
+  private void mergeAndPush()
+  {
+    final Granularity segmentGranularity = schema.getGranularitySpec().getSegmentGranularity();
+    final Period windowPeriod = config.getWindowPeriod();
+
+    final long windowMillis = windowPeriod.toStandardDuration().getMillis();
+    log.info("Starting merge and push.");
+
+    DateTime minTimestampAsDate = segmentGranularity.truncate(
+        rejectionPolicy.getCurrMaxTime().minus(windowMillis)
+    );
+    long minTimestamp = minTimestampAsDate.getMillis();
+
+    log.info("Found [%,d] sinks. minTimestamp [%s]", sinks.size(), minTimestampAsDate);
+
+    List<Map.Entry<Long, Sink>> sinksToPush = Lists.newArrayList();
+    for (Map.Entry<Long, Sink> entry : sinks.entrySet()) {
+      final Long intervalStart = entry.getKey();
+      if (intervalStart < minTimestamp) {
+        log.info("Adding entry[%s] for merge and push.", entry);
+        sinksToPush.add(entry);
+      } else {
+        log.warn(
+            "[%s] < [%s] Skipping persist and merge.",
+            new DateTime(intervalStart),
+            minTimestampAsDate
+        );
+      }
+    }
+
+    log.info("Found [%,d] sinks to persist and merge", sinksToPush.size());
+
+    for (final Map.Entry<Long, Sink> entry : sinksToPush) {
+      persistAndMerge(entry.getKey(), entry.getValue());
+    }
+  }
+
   /**
    * Unannounces a given sink and removes all local references to it.
    */