Apache
/
druid
mirror of https://github.com/apache/druid.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #1180 from metamx/logging-groupBy-NPE 

add null check early to catch root cause for groupBy NPE while running bySegment query
This commit is contained in:
Fangjin Yang 2015-03-09 09:16:33 -07:00
parent 88a1d1e048 704f463dbf
commit 2abdce1dc0
3 changed files with 5 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
docs/content/Broker-Config.md
View File

@ -76,7 +76,7 @@ You can optionally only configure caching to be enabled on the broker by setting
|`druid.broker.cache.useCache`|true, false|Enable the cache on the broker.|false|
|`druid.broker.cache.populateCache`|true, false|Populate the cache on the broker.|false|
|`druid.cache.type`|`local`, `memcached`|The type of cache to use for queries.|`local`|
|`druid.cache.unCacheable`|All druid query types|All query types to not cache.|["groupBy", "select"]|
|`druid.broker.cache.unCacheable`|All druid query types|All query types to not cache.|["groupBy", "select"]|
#### Local Cache

2
docs/content/Historical-Config.md
View File

@ -81,7 +81,7 @@ You can optionally only configure caching to be enabled on the historical by set
|`druid.historical.cache.useCache`|true, false|Enable the cache on the historical.|false|
|`druid.historical.cache.populateCache`|true, false|Populate the cache on the historical.|false|
|`druid.cache.type`|`local`, `memcached`|The type of cache to use for queries.|`local`|
|`druid.cache.unCacheable`|All druid query types|All query types to not cache.|["groupBy", "select"]|
|`druid.historical.cache.unCacheable`|All druid query types|All query types to not cache.|["groupBy", "select"]|
#### Local Cache

3
processing/src/main/java/io/druid/query/groupby/GroupByQueryHelper.java
View File

@ -138,6 +138,9 @@ public class GroupByQueryHelper
@Override
public List accumulate(List accumulated, T in)
{
if(in == null){
throw new ISE("Cannot have null result");
}
accumulated.add(in);
return accumulated;
}