Apache/druid
1
0
Fork 0
mirror of https://github.com/apache/druid.git synced 2025-02-17 07:25:02 +00:00
Code Issues Packages Projects Releases Wiki Activity

Web console: fix bad results if there is not native bigint (#10741)

Browse Source 
* fix bigint when it does not exist

* add test
This commit is contained in:
Vadim Ogievetsky 2021-01-12 16:32:23 -08:00 committed by GitHub
parent aecc9e5e7e
commit 2fc2938b01
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
4 changed files with 40 additions and 38 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

34
licenses.yaml
View File

@ -4968,16 +4968,6 @@ license_file_path: licenses/bin/d3-time.BSD3
---
name: "debug"
license_category: binary
module: web-console
license_name: MIT License
copyright: TJ Holowaychuk
version: 3.1.0
license_file_path: licenses/bin/debug.MIT
---
name: "deep-equal"
license_category: binary
module: web-console
@ -5051,7 +5041,7 @@ license_category: binary
module: web-console
license_name: MIT License
copyright: Ruben Verborgh
version: 1.5.10
version: 1.13.1
license_file_path: licenses/bin/follow-redirects.MIT
---
@ -5146,16 +5136,6 @@ license_file_path: licenses/bin/is-arguments.MIT
---
name: "is-buffer"
license_category: binary
module: web-console
license_name: MIT License
copyright: Feross Aboukhadijeh
version: 2.0.3
license_file_path: licenses/bin/is-buffer.MIT
---
name: "is-date-object"
license_category: binary
module: web-console
@ -5201,7 +5181,7 @@ license_category: binary
module: web-console
license_name: MIT License
copyright: Vadim Ogievetsky, Andrey Sidorov
version: 1.0.0
version: 1.1.0
license_file_path: licenses/bin/json-bigint-native.MIT
---
@ -5276,16 +5256,6 @@ license_file_path: licenses/bin/mini-create-react-context.MIT
---
name: "ms"
license_category: binary
module: web-console
license_name: MIT License
copyright: Zeit, Inc.
version: 2.0.0
license_file_path: licenses/bin/ms.MIT
---
name: "normalize.css"
license_category: binary
module: web-console

14
web-console/package-lock.json generated
View File

@ -3913,6 +3913,7 @@
"version": "3.1.0",
"resolved": "https://registry.npmjs.org/debug/-/debug-3.1.0.tgz",
"integrity": "sha512-OX8XqP7/1a9cqkxYw2yXss15f26NKWBpDXQd0/uK/KPqdQhxbPa994hnzjcE2VqQpDslf55723cKPUOGSmMY3g==",
"dev": true,
"requires": {
"ms": "2.0.0"
}
@ -5311,6 +5312,7 @@
"version": "1.5.10",
"resolved": "https://registry.npmjs.org/follow-redirects/-/follow-redirects-1.5.10.tgz",
"integrity": "sha512-0V5l4Cizzvqt5D44aTXbFZz+FtyXV1vrDN6qrelxtfYQKW0KO0W2T/hkE8xvGa/540LkZlkaUjO4ailYTFtHVQ==",
"dev": true,
"requires": {
"debug": "=3.1.0"
}
@ -6969,7 +6971,8 @@
"is-buffer": {
"version": "2.0.3",
"resolved": "https://registry.npmjs.org/is-buffer/-/is-buffer-2.0.3.tgz",
"integrity": "sha512-U15Q7MXTuZlrbymiz95PJpZxu8IlipAp4dtS3wOdgPXx3mqBnslrWU14kxfHB+Py/+2PVKSr37dMAgM2A4uArw=="
"integrity": "sha512-U15Q7MXTuZlrbymiz95PJpZxu8IlipAp4dtS3wOdgPXx3mqBnslrWU14kxfHB+Py/+2PVKSr37dMAgM2A4uArw==",
"dev": true
},
"is-callable": {
"version": "1.1.4",
@ -8044,9 +8047,9 @@
"dev": true
},
"json-bigint-native": {
"version": "1.0.0",
"resolved": "https://registry.npmjs.org/json-bigint-native/-/json-bigint-native-1.0.0.tgz",
"integrity": "sha512-upUMnqV96WRGAbopHwDFHxsJbdBZRAdZW3WEJTB/WMLUseDEhJkcOQ0qr5x+JOHwIWpI9BYc6zoVJkmbL7SMLA=="
"version": "1.1.0",
"resolved": "https://registry.npmjs.org/json-bigint-native/-/json-bigint-native-1.1.0.tgz",
"integrity": "sha512-PPL9AlDP0ift5v8siEsR7oQsamOAIOLjn14GRaijZRUWDXsJC5rHXNlmtLPkPjK0k2i5yHK30VPqiFTZHolXaA=="
},
"json-parse-better-errors": {
"version": "1.0.2",
@ -8841,7 +8844,8 @@
"ms": {
"version": "2.0.0",
"resolved": "https://registry.npmjs.org/ms/-/ms-2.0.0.tgz",
"integrity": "sha1-VgiurfwAvmwpAd9fmGF4jeDVl8g="
"integrity": "sha1-VgiurfwAvmwpAd9fmGF4jeDVl8g=",
"dev": true
},
"multicast-dns": {
"version": "6.2.3",

2
web-console/package.json
View File

@ -74,7 +74,7 @@
"fontsource-open-sans": "^3.0.9",
"has-own-prop": "^2.0.0",
"hjson": "^3.2.1",
"json-bigint-native": "^1.0.0",
"json-bigint-native": "^1.1.0",
"lodash.debounce": "^4.0.8",
"lodash.escape": "^4.0.1",
"memoize-one": "^5.1.1",

28
web-console/src/singletons/api.spec.ts
View File

@ -23,4 +23,32 @@ describe('Api', () => {
expect(Api.encodePath('wikipedia')).toEqual('wikipedia');
expect(Api.encodePath(`wi%ki?pe#dia&'[]`)).toEqual('wi%25ki%3Fpe%23dia%26%27%5B%5D');
});
describe(`with BigInt`, () => {
it('works as expected', () => {
const res = (Api.getDefaultConfig().transformResponse as any)[0](`{"x":9223372036854775799}`);
expect(typeof res).toEqual('object');
expect(typeof res.x).toEqual('bigint');
expect(String(res.x)).toEqual('9223372036854775799');
});
});
describe(`without BigInt`, () => {
const originalBigInt = (global as any).BigInt;
beforeAll(() => {
(global as any).BigInt = null;
});
afterAll(() => {
(global as any).BigInt = originalBigInt;
});
it('works as expected', () => {
const res = (Api.getDefaultConfig().transformResponse as any)[0](`{"x":9223372036854775799}`);
expect(typeof res).toEqual('object');
expect(typeof res.x).toEqual('number');
expect(String(res.x)).toEqual('9223372036854776000');
});
});
});