Apache
/
druid
mirror of https://github.com/apache/druid.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

fix a race condition of ParseCtx (#4791)

This commit is contained in:
Dayue Gao 2017-09-13 12:03:48 -05:00 committed by Gian Merlino
parent eb6791a60c
commit 39a0b171e8
1 changed files with 6 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
api/src/main/java/io/druid/data/input/impl/TimestampSpec.java
View File

@ -53,7 +53,7 @@ public class TimestampSpec
private final Function<Object, DateTime> timestampConverter;
// remember last value parsed
private transient ParseCtx parseCtx = new ParseCtx();
private static final ThreadLocal<ParseCtx> parseCtx = ThreadLocal.withInitial(ParseCtx::new);
@JsonCreator
public TimestampSpec(
@ -98,15 +98,16 @@ public class TimestampSpec
{
DateTime extracted = missingValue;
if (input != null) {
ParseCtx ctx = parseCtx.get();
// Check if the input is equal to the last input, so we don't need to parse it again
if (input.equals(parseCtx.lastTimeObject)) {
extracted = parseCtx.lastDateTime;
if (input.equals(ctx.lastTimeObject)) {
extracted = ctx.lastDateTime;
} else {
extracted = timestampConverter.apply(input);
ParseCtx newCtx = new ParseCtx();
newCtx.lastTimeObject = input;
extracted = timestampConverter.apply(input);
newCtx.lastDateTime = extracted;
parseCtx = newCtx;
parseCtx.set(newCtx);
}
}
return extracted;