diff --git a/dev/code-review/concurrency.md b/dev/code-review/concurrency.md index 9bbb82a4c6d..2637bdfb17e 100644 --- a/dev/code-review/concurrency.md +++ b/dev/code-review/concurrency.md @@ -108,6 +108,8 @@ Testing https://github.com/code-review-checklists/java-concurrency#coordinate-test-workers) - [There are more test threads than CPUs (if possible for the test)?]( https://github.com/code-review-checklists/java-concurrency#test-workers-interleavings) + - [Assertions in parallel threads and asynchronous code are handled properly?]( + https://github.com/code-review-checklists/java-concurrency#concurrent-assert) Locks - [Can use `LifecycleLock` instead of a standard lock in a lifecycled object?](#use-lifecycle-lock) @@ -245,4 +247,4 @@ daemon threads already. [#](#use-execs) TE.D2. Is it possible to use one of the static factory methods in Druid's `Execs` utility class to create an `ExecutorService` instead of Java's standard `ExecutorServices`? This is recommended because `Execs` configure -ThreadFactories to create daemon threads by default, as required by the previous item. \ No newline at end of file +ThreadFactories to create daemon threads by default, as required by the previous item.