Apache
/
druid
mirror of https://github.com/apache/druid.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Fix the uncaught exceptions when materializing results as frames (#14970) 

When materializing the results as frames, we defer the creation of the frames in ScanQueryQueryToolChest, which passes through the catch-all block reserved for catching cases when we don't have the complete row signature in the query (and falls back to the old code).
This PR aims to resolve it by adding the frame generation code to the try-catch block we have at the outer level.
This commit is contained in:
Laksh Singla 2023-09-13 10:11:28 +00:00 committed by GitHub
parent b7bb5ee1db
commit 4c57504960
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 112 additions and 23 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

31
server/src/main/java/org/apache/druid/server/ClientQuerySegmentWalker.java
View File

@ -767,22 +767,9 @@ public class ClientQuerySegmentWalker implements QuerySegmentWalker
new ArenaMemoryAllocatorFactory(FRAME_SIZE),
useNestedForUnknownTypeInSubquery
);
}
catch (UnsupportedColumnTypeException e) {
subqueryStatsProvider.incrementSubqueriesFallingBackDueToUnsufficientTypeInfo();
log.debug(e, "Type info in signature insufficient to materialize rows as frames.");
return Optional.empty();
}
catch (Exception e) {
subqueryStatsProvider.incrementSubqueriesFallingBackDueToUnknownReason();
log.debug(e, "Unable to materialize the results as frames due to an unhandleable exception "
+ "while conversion. Defaulting to materializing the results as rows");
return Optional.empty();
}
if (!framesOptional.isPresent()) {
log.debug("Unable to materialize the results as frames. Defaulting to materializing the results as rows");
return Optional.empty();
throw DruidException.defensive("Unable to materialize the results as frames. Defaulting to materializing the results as rows");
}
Sequence<FrameSignaturePair> frames = framesOptional.get();
@ -802,6 +789,22 @@ public class ClientQuerySegmentWalker implements QuerySegmentWalker
}
);
return Optional.of(new FrameBasedInlineDataSource(frameSignaturePairs, toolChest.resultArraySignature(query)));
}
catch (ResourceLimitExceededException e) {
throw e;
}
catch (UnsupportedColumnTypeException e) {
subqueryStatsProvider.incrementSubqueriesFallingBackDueToUnsufficientTypeInfo();
log.debug(e, "Type info in signature insufficient to materialize rows as frames.");
return Optional.empty();
}
catch (Exception e) {
subqueryStatsProvider.incrementSubqueriesFallingBackDueToUnknownReason();
log.debug(e, "Unable to materialize the results as frames due to an unhandleable exception "
+ "while conversion. Defaulting to materializing the results as rows");
return Optional.empty();
}
}
/**

86
sql/src/test/java/org/apache/druid/sql/calcite/CalciteSubqueryTest.java
View File

@ -951,4 +951,90 @@ public class CalciteSubqueryTest extends BaseCalciteQueryTest
)
);
}
@Test
public void testJoinWithSubqueries()
{
cannotVectorize();
List<Object[]> results = new ArrayList<>(ImmutableList.of(
new Object[]{"", NullHandling.defaultStringValue()},
new Object[]{"10.1", NullHandling.defaultStringValue()},
new Object[]{"2", NullHandling.defaultStringValue()},
new Object[]{"1", NullHandling.defaultStringValue()},
new Object[]{"def", NullHandling.defaultStringValue()},
new Object[]{"abc", NullHandling.defaultStringValue()}
));
if (NullHandling.replaceWithDefault()) {
results.add(new Object[]{NullHandling.defaultStringValue(), NullHandling.defaultStringValue()});
}
testQuery(
"SELECT a.dim1, b.dim2\n"
+ "FROM (SELECT na.dim1 as dim1, nb.dim2 as dim2 FROM foo na LEFT JOIN foo2 nb ON na.dim1 = nb.dim1) a\n"
+ "FULL OUTER JOIN\n"
+ "(SELECT nc.dim1 as dim1, nd.dim2 as dim2 FROM foo nc LEFT JOIN foo2 nd ON nc.dim1 = nd.dim1) b\n"
+ "ON a.dim1 = b.dim1",
queryContext,
ImmutableList.of(
newScanQueryBuilder()
.dataSource(
JoinDataSource.create(
JoinDataSource.create(
new TableDataSource("foo"),
new QueryDataSource(
newScanQueryBuilder()
.dataSource("foo2")
.columns("dim1")
.eternityInterval()
.build()
),
"j0.",
"(\"dim1\" == \"j0.dim1\")",
JoinType.LEFT,
null,
ExprMacroTable.nil(),
CalciteTests.createJoinableFactoryWrapper()
),
new QueryDataSource(
newScanQueryBuilder()
.dataSource(
JoinDataSource.create(
new TableDataSource("foo"),
new QueryDataSource(
newScanQueryBuilder()
.dataSource("foo2")
.columns("dim1", "dim2")
.eternityInterval()
.build()
),
"j0.",
"(\"dim1\" == \"j0.dim1\")",
JoinType.LEFT,
null,
ExprMacroTable.nil(),
CalciteTests.createJoinableFactoryWrapper()
)
)
.columns("dim1", "j0.dim2")
.eternityInterval()
.build()
),
"_j0.",
"(\"dim1\" == \"_j0.dim1\")",
JoinType.FULL,
null,
ExprMacroTable.nil(),
CalciteTests.createJoinableFactoryWrapper()
)
)
.columns("_j0.j0.dim2", "dim1")
.eternityInterval()
.build()
),
results
);
}
}