Apache
/
druid
mirror of https://github.com/apache/druid.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Web console: better lookup 404 detection (#14108) 

* better lookup 404 detection

* update snapshot
This commit is contained in:
Vadim Ogievetsky 2023-04-19 09:27:55 -07:00 committed by GitHub
parent e8674e2a60
commit 4fffee1776
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 5 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
web-console/src/utils/druid-lookup.ts
View File

@ -16,6 +16,8 @@
* limitations under the License. * limitations under the License.
*/ */
import { deepGet } from './object-change';
export function isLookupsUninitialized(error: Error | undefined) { export function isLookupsUninitialized(error: Error | undefined) {
return error && error.message === 'Request failed with status code 404'; return deepGet(error || {}, 'response.status') === 404;
} }

2
web-console/src/views/lookups-view/__snapshots__/lookups-view.spec.tsx.snap
View File

@ -210,7 +210,7 @@ exports[`LookupsView matches snapshot 1`] = `
multiSort={true} multiSort={true}
nestingLevelKey="_nestingLevel" nestingLevelKey="_nestingLevel"
nextText="Next" nextText="Next"
noDataText="" noDataText="No lookups"
ofText="of" ofText="of"
onFetchData={[Function]} onFetchData={[Function]}
onFilteredChange={[Function]} onFilteredChange={[Function]}

6
web-console/src/views/lookups-view/lookups-view.tsx
View File

@ -355,11 +355,7 @@ export class LookupsView extends React.PureComponent<LookupsViewProps, LookupsVi
<ReactTable <ReactTable
data={lookups} data={lookups}
loading={lookupEntriesAndTiersState.loading} loading={lookupEntriesAndTiersState.loading}
noDataText={ noDataText={lookupEntriesAndTiersState.getErrorMessage() || 'No lookups'}
!lookupEntriesAndTiersState.loading && !lookups.length
? 'No lookups'
: lookupEntriesAndTiersState.getErrorMessage() || ''
}
filterable filterable
filtered={lookupFilter} filtered={lookupFilter}
onFilteredChange={filtered => { onFilteredChange={filtered => {