Apache
/
druid
mirror of https://github.com/apache/druid.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Enable conversion of join to filter by default (#12868)

This commit is contained in:
Rohan Garg 2022-08-13 20:37:43 +05:30 committed by GitHub
parent af700bba0c
commit 5394838030
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
4 changed files with 3 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
docs/querying/query-context.md
View File

@ -93,6 +93,7 @@ Some query types offer context parameters specific to that query type.
|enableJoinFilterPushDown | `true` | Controls whether a join query will attempt filter push down, which reduces the number of rows that have to be compared in a join operation.| |enableJoinFilterPushDown | `true` | Controls whether a join query will attempt filter push down, which reduces the number of rows that have to be compared in a join operation.|
|enableJoinFilterRewrite | `true` | Controls whether filter clauses that reference non-base table columns will be rewritten into filters on base table columns.| |enableJoinFilterRewrite | `true` | Controls whether filter clauses that reference non-base table columns will be rewritten into filters on base table columns.|
|enableJoinFilterRewriteValueColumnFilters | `false` | Controls whether Druid rewrites non-base table filters on non-key columns in the non-base table. Requires a scan of the non-base table.| |enableJoinFilterRewriteValueColumnFilters | `false` | Controls whether Druid rewrites non-base table filters on non-key columns in the non-base table. Requires a scan of the non-base table.|
|enableRewriteJoinToFilter | `true` | Controls whether a join can be pushed partial or fully to the base table as a filter at runtime.|
|joinFilterRewriteMaxSize | `10000` | The maximum size of the correlated value set used for filter rewrites. Set this limit to prevent excessive memory use.| |joinFilterRewriteMaxSize | `10000` | The maximum size of the correlated value set used for filter rewrites. Set this limit to prevent excessive memory use.|
### GroupBy ### GroupBy

2
processing/src/main/java/org/apache/druid/query/QueryContexts.java
View File

@ -95,7 +95,7 @@ public class QueryContexts
public static final boolean DEFAULT_ENABLE_JOIN_FILTER_PUSH_DOWN = true; public static final boolean DEFAULT_ENABLE_JOIN_FILTER_PUSH_DOWN = true;
public static final boolean DEFAULT_ENABLE_JOIN_FILTER_REWRITE = true; public static final boolean DEFAULT_ENABLE_JOIN_FILTER_REWRITE = true;
public static final boolean DEFAULT_ENABLE_JOIN_FILTER_REWRITE_VALUE_COLUMN_FILTERS = false; public static final boolean DEFAULT_ENABLE_JOIN_FILTER_REWRITE_VALUE_COLUMN_FILTERS = false;
public static final boolean DEFAULT_ENABLE_REWRITE_JOIN_TO_FILTER = false; public static final boolean DEFAULT_ENABLE_REWRITE_JOIN_TO_FILTER = true;
public static final long DEFAULT_ENABLE_JOIN_FILTER_REWRITE_MAX_SIZE = 10000; public static final long DEFAULT_ENABLE_JOIN_FILTER_REWRITE_MAX_SIZE = 10000;
public static final boolean DEFAULT_ENABLE_SQL_JOIN_LEFT_SCAN_DIRECT = false; public static final boolean DEFAULT_ENABLE_SQL_JOIN_LEFT_SCAN_DIRECT = false;
public static final boolean DEFAULT_USE_FILTER_CNF = false; public static final boolean DEFAULT_USE_FILTER_CNF = false;

3
sql/src/test/java/org/apache/druid/sql/calcite/CalciteQueryTest.java
View File

@ -3843,9 +3843,6 @@ public class CalciteQueryTest extends BaseCalciteQueryTest
@Test @Test
public void testGroupingWithNullInFilter() throws Exception public void testGroupingWithNullInFilter() throws Exception
{ {
// HashJoinSegmentStorageAdapter is not vectorizable
cannotVectorize();
testQuery( testQuery(
"SELECT COUNT(*) FROM foo WHERE dim1 IN (NULL)", "SELECT COUNT(*) FROM foo WHERE dim1 IN (NULL)",
ImmutableList.of( ImmutableList.of(

1
website/.spelling
View File

@ -1652,6 +1652,7 @@ enableParallelMerge
enableJoinLeftTableScanDirect enableJoinLeftTableScanDirect
enableJoinFilterPushDown enableJoinFilterPushDown
enableJoinFilterRewrite enableJoinFilterRewrite
enableRewriteJoinToFilter
enableJoinFilterRewriteValueColumnFilters enableJoinFilterRewriteValueColumnFilters
floatSum floatSum
joinFilterRewriteMaxSize joinFilterRewriteMaxSize