Apache
/
druid
mirror of https://github.com/apache/druid.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

adjust PR template (#8016)

This commit is contained in:
Clint Wylie 2019-07-03 08:31:31 -07:00 committed by Fangjin Yang
parent 3b84246cd6
commit 53a32b6f55
1 changed files with 2 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
.github/pull_request_template.md vendored
View File

@ -43,13 +43,10 @@ Some of the aspects mentioned above may be omitted for simple and small changes.
This PR has: This PR has:
- [ ] been self-reviewed. - [ ] been self-reviewed.
- [ ] using the [concurrency checklist]( - [ ] using the [concurrency checklist](https://github.com/apache/incubator-druid/blob/master/dev/code-review/concurrency.md) (Remove this item if the PR doesn't have any relation to concurrency.)
https://github.com/apache/incubator-druid/blob/master/dev/code-review/concurrency.md) (Remove this item if the PR
doesn't have any relation to concurrency.)
- [ ] added documentation for new or modified features or behaviors. - [ ] added documentation for new or modified features or behaviors.
- [ ] added Javadocs for most classes and all non-trivial methods. Linked related entities via Javadoc links. - [ ] added Javadocs for most classes and all non-trivial methods. Linked related entities via Javadoc links.
- [ ] added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar - [ ] added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
reader.
- [ ] added unit tests or modified existing tests to cover new code paths. - [ ] added unit tests or modified existing tests to cover new code paths.
- [ ] added integration tests. - [ ] added integration tests.
- [ ] been tested in a test Druid cluster. - [ ] been tested in a test Druid cluster.