Apache
/
druid
mirror of https://github.com/apache/druid.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Improve logging in CoordinatorBasedSegmentHandoffNotifier (#14640)

This commit is contained in:
aho135 2023-07-24 05:34:21 -07:00 committed by GitHub
parent 536e491d00
commit 607f511767
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 8 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
server/src/main/java/org/apache/druid/segment/handoff/CoordinatorBasedSegmentHandoffNotifier.java
View File

@ -26,6 +26,7 @@ import org.apache.druid.java.util.common.concurrent.Execs;
import org.apache.druid.java.util.common.logger.Logger; import org.apache.druid.java.util.common.logger.Logger;
import org.apache.druid.query.SegmentDescriptor; import org.apache.druid.query.SegmentDescriptor;
import org.apache.druid.server.coordination.DruidServerMetadata; import org.apache.druid.server.coordination.DruidServerMetadata;
import org.joda.time.Duration;
import java.util.Iterator; import java.util.Iterator;
import java.util.List; import java.util.List;
@ -43,7 +44,7 @@ public class CoordinatorBasedSegmentHandoffNotifier implements SegmentHandoffNot
private final ConcurrentMap<SegmentDescriptor, Pair<Executor, Runnable>> handOffCallbacks = new ConcurrentHashMap<>(); private final ConcurrentMap<SegmentDescriptor, Pair<Executor, Runnable>> handOffCallbacks = new ConcurrentHashMap<>();
private final CoordinatorClient coordinatorClient; private final CoordinatorClient coordinatorClient;
private volatile ScheduledExecutorService scheduledExecutor; private volatile ScheduledExecutorService scheduledExecutor;
private final long pollDurationMillis; private final Duration pollDuration;
private final String dataSource; private final String dataSource;
public CoordinatorBasedSegmentHandoffNotifier( public CoordinatorBasedSegmentHandoffNotifier(
@ -54,7 +55,7 @@ public class CoordinatorBasedSegmentHandoffNotifier implements SegmentHandoffNot
{ {
this.dataSource = dataSource; this.dataSource = dataSource;
this.coordinatorClient = coordinatorClient; this.coordinatorClient = coordinatorClient;
this.pollDurationMillis = config.getPollDuration().getMillis(); this.pollDuration = config.getPollDuration();
} }
@Override @Override
@ -80,7 +81,7 @@ public class CoordinatorBasedSegmentHandoffNotifier implements SegmentHandoffNot
{ {
checkForSegmentHandoffs(); checkForSegmentHandoffs();
} }
}, 0L, pollDurationMillis, TimeUnit.MILLISECONDS }, 0L, pollDuration.getMillis(), TimeUnit.MILLISECONDS
); );
} }
@ -114,10 +115,10 @@ public class CoordinatorBasedSegmentHandoffNotifier implements SegmentHandoffNot
catch (Exception e) { catch (Exception e) {
log.error( log.error(
e, e,
"Exception while checking handoff for dataSource[%s] Segment[%s], Will try again after [%d]secs", "Exception while checking handoff for dataSource[%s] Segment[%s]; will try again after [%s]",
dataSource, dataSource,
descriptor, descriptor,
pollDurationMillis pollDuration
); );
} }
} }
@ -128,9 +129,9 @@ public class CoordinatorBasedSegmentHandoffNotifier implements SegmentHandoffNot
catch (Throwable t) { catch (Throwable t) {
log.error( log.error(
t, t,
"Exception while checking handoff for dataSource[%s], Will try again after [%d]secs", "Exception while checking handoff for dataSource[%s]; will try again after [%s]",
dataSource, dataSource,
pollDurationMillis pollDuration
); );
} }
} }