Apache
/
druid
mirror of https://github.com/apache/druid.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Fix bugs in milestone contributor script (#7545) 

* Only check PRs in milestone contributor script

* Fix no-pagination bug
This commit is contained in:
Jonathan Wei 2019-04-24 22:11:57 -07:00 committed by Fangjin Yang
parent 3e25b75c3f
commit 658fb2b062
1 changed files with 13 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

20
docs/_bin/get-milestone-contributors.py
View File

@ -36,18 +36,24 @@ contributors = set()
# Get all users who created a closed issue or merged PR for a given milestone
while not done:
resp = requests.get("https://api.github.com/repos/apache/incubator-druid/issues?milestone=%s&state=closed&page=%s" % (milestone_num, page_counter))
pagination_link = resp.headers["Link"]
# last page doesn't have a "next"
if "rel=\"next\"" not in pagination_link:
done = True
if "Link" in resp.headers:
pagination_link = resp.headers["Link"]
# last page doesn't have a "next"
if "rel=\"next\"" not in pagination_link:
done = True
else:
page_counter += 1
else:
page_counter += 1
# Not enough issues to require pagination
done = True
issues = json.loads(resp.text)
for issue in issues:
contributor_name = issue["user"]["login"]
contributors.add(contributor_name)
if "pull_request" in issue:
contributor_name = issue["user"]["login"]
contributors.add(contributor_name)
# doesn't work as-is for python2, the contributor names are "unicode" instead of "str" in python2
contributors = sorted(contributors, key=str.lower)