From 5e178499e897d44290d858360c6b74e43681e1b3 Mon Sep 17 00:00:00 2001 From: Himanshu Gupta Date: Mon, 21 Dec 2015 00:11:20 -0600 Subject: [PATCH] trying to fix transient errors in testRealtimeIndexTask() by increasing overall timeout and unlimited wait for segment publish --- .../java/io/druid/indexing/overlord/TaskLifecycleTest.java | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/indexing-service/src/test/java/io/druid/indexing/overlord/TaskLifecycleTest.java b/indexing-service/src/test/java/io/druid/indexing/overlord/TaskLifecycleTest.java index 171cdbfeb4f..26c3d168c7e 100644 --- a/indexing-service/src/test/java/io/druid/indexing/overlord/TaskLifecycleTest.java +++ b/indexing-service/src/test/java/io/druid/indexing/overlord/TaskLifecycleTest.java @@ -60,7 +60,6 @@ import io.druid.indexing.common.TestUtils; import io.druid.indexing.common.actions.LocalTaskActionClientFactory; import io.druid.indexing.common.actions.LockListAction; import io.druid.indexing.common.actions.SegmentInsertAction; -import io.druid.indexing.common.actions.TaskActionClient; import io.druid.indexing.common.actions.TaskActionClientFactory; import io.druid.indexing.common.actions.TaskActionToolbox; import io.druid.indexing.common.config.TaskConfig; @@ -127,7 +126,6 @@ import java.util.Map; import java.util.Set; import java.util.concurrent.CountDownLatch; import java.util.concurrent.Executor; -import java.util.concurrent.TimeUnit; @RunWith(Parameterized.class) public class TaskLifecycleTest @@ -866,7 +864,7 @@ public class TaskLifecycleTest Assert.assertEquals("segments nuked", 0, mdc.getNuked().size()); } - @Test(timeout = 4000L) + @Test(timeout = 10000L) public void testRealtimeIndexTask() throws Exception { monitorScheduler.addMonitor(EasyMock.anyObject(Monitor.class)); @@ -880,7 +878,7 @@ public class TaskLifecycleTest tq.add(realtimeIndexTask); //wait for task to process events and publish segment - Assert.assertTrue(publishCountDown.await(1000, TimeUnit.MILLISECONDS)); + publishCountDown.await(); // Realtime Task has published the segment, simulate loading of segment to a historical node so that task finishes with SUCCESS status Assert.assertEquals(1, handOffCallbacks.size());