Apache
/
druid
mirror of https://github.com/apache/druid.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Improve error message when task fails before becoming ready (#16286)

This commit is contained in:
YongGang 2024-04-17 19:45:41 -07:00 committed by GitHub
parent 3f2dd46ede
commit 6974498d98
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 7 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
indexing-service/src/main/java/org/apache/druid/indexing/overlord/TaskQueue.java
View File

@ -427,8 +427,10 @@ public class TaskQueue
if (e instanceof MaxAllowedLocksExceededException) { if (e instanceof MaxAllowedLocksExceededException) {
errorMessage = e.getMessage(); errorMessage = e.getMessage();
} else { } else {
errorMessage = "Failed while waiting for the task to be ready to run. " errorMessage = StringUtils.format(
+ "See overlord logs for more details."; "Encountered error[%s] while waiting for task to be ready. See Overlord logs for more details.",
StringUtils.chop(e.getMessage(), 100)
);
} }
notifyStatus(task, TaskStatus.failure(task.getId(), errorMessage), errorMessage); notifyStatus(task, TaskStatus.failure(task.getId(), errorMessage), errorMessage);
continue; continue;

5
indexing-service/src/test/java/org/apache/druid/indexing/overlord/TaskQueueTest.java
View File

@ -298,12 +298,13 @@ public class TaskQueueTest extends IngestionTestBase
@Test @Test
public void testExceptionInIsReadyFailsTask() public void testExceptionInIsReadyFailsTask()
{ {
final String exceptionMsg = "isReady failure test";
final Task task = new TestTask("t1", Intervals.of("2021-01-01/P1D")) final Task task = new TestTask("t1", Intervals.of("2021-01-01/P1D"))
{ {
@Override @Override
public boolean isReady(TaskActionClient taskActionClient) public boolean isReady(TaskActionClient taskActionClient)
{ {
throw new RuntimeException("isReady failure test"); throw new RuntimeException(exceptionMsg);
} }
}; };
taskQueue.add(task); taskQueue.add(task);
@ -314,7 +315,7 @@ public class TaskQueueTest extends IngestionTestBase
Assert.assertEquals(TaskState.FAILED, statusOptional.get().getStatusCode()); Assert.assertEquals(TaskState.FAILED, statusOptional.get().getStatusCode());
Assert.assertNotNull(statusOptional.get().getErrorMsg()); Assert.assertNotNull(statusOptional.get().getErrorMsg());
Assert.assertTrue( Assert.assertTrue(
statusOptional.get().getErrorMsg().startsWith("Failed while waiting for the task to be ready to run") statusOptional.get().getErrorMsg().contains(exceptionMsg)
); );
} }