Apache
/
druid
mirror of https://github.com/apache/druid.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Fix a comment in the Calcite UT testExactCountDistinctWithFilter (#14628)

This commit is contained in:
Adarsh Sanjeev 2023-07-26 12:02:26 +05:30 committed by GitHub
parent 52fbc6939e
commit 6a42a24426
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 16 additions and 19 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

35
sql/src/test/java/org/apache/druid/sql/calcite/CalciteQueryTest.java
View File

@ -2334,26 +2334,23 @@ public class CalciteQueryTest extends BaseCalciteQueryTest
{
notMsqCompatible();
final String sqlQuery = "SELECT COUNT(DISTINCT foo.dim1) FILTER(WHERE foo.cnt = 1), SUM(foo.cnt) FROM druid.foo";
// When useApproximateCountDistinct=true and useGroupingSetForExactDistinct=false, planning fails due
// When useApproximateCountDistinct=false and useGroupingSetForExactDistinct=false, planning fails due
// to a bug in the Calcite's rule (AggregateExpandDistinctAggregatesRule)
try {
testQuery(
PLANNER_CONFIG_NO_HLL.withOverrides(
ImmutableMap.of(
PlannerConfig.CTX_KEY_USE_GROUPING_SET_FOR_EXACT_DISTINCT,
"false"
)
), // Enable exact count distinct
sqlQuery,
CalciteTests.REGULAR_USER_AUTH_RESULT,
ImmutableList.of(),
ImmutableList.of()
);
Assert.fail("query execution should fail");
}
catch (RuntimeException e) {
Assert.assertTrue(e.getMessage().contains("Error while applying rule AggregateExpandDistinctAggregatesRule"));
}
Assert.assertThrows(
RuntimeException.class,
() -> testQuery(
PLANNER_CONFIG_NO_HLL.withOverrides(
ImmutableMap.of(
PlannerConfig.CTX_KEY_USE_GROUPING_SET_FOR_EXACT_DISTINCT, "false",
PlannerConfig.CTX_KEY_USE_APPROXIMATE_COUNT_DISTINCT, false
)
), // Enable exact count distinct
sqlQuery,
CalciteTests.REGULAR_USER_AUTH_RESULT,
ImmutableList.of(),
ImmutableList.of()
)
);
requireMergeBuffers(3);
testQuery(