Apache
/
druid
mirror of https://github.com/apache/druid.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Remove StorageAdapter.getColumnTypeName. (#11893) 

* Remove StorageAdapter.getColumnTypeName.

It was only used by SegmentAnalyzer, and isn't necessary anymore due to
the recent improvements to ColumnCapabilities.

Also: tidy ColumnDescriptor.read slightly by removing an instanceof
check, and moving the relevant logic into ComplexColumnPartSerde.

* Fix spellings.
This commit is contained in:
Gian Merlino 2021-11-09 15:18:07 -08:00 committed by GitHub
parent 324d4374f6
commit 6c196a5ea2
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
14 changed files with 94 additions and 137 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
processing/src/main/java/org/apache/druid/query/metadata/SegmentAnalyzer.java
View File

@ -45,6 +45,8 @@ import org.apache.druid.segment.column.ColumnHolder;
import org.apache.druid.segment.column.ColumnType;
import org.apache.druid.segment.column.ComplexColumn;
import org.apache.druid.segment.column.DictionaryEncodedColumn;
import org.apache.druid.segment.column.TypeSignature;
import org.apache.druid.segment.column.ValueType;
import org.apache.druid.segment.data.IndexedInts;
import org.apache.druid.segment.incremental.IncrementalIndexStorageAdapter;
import org.apache.druid.segment.serde.ComplexMetricSerde;
@ -137,7 +139,7 @@ public class SegmentAnalyzer
}
break;
case COMPLEX:
analysis = analyzeComplexColumn(capabilities, columnHolder, storageAdapter.getColumnTypeName(columnName));
analysis = analyzeComplexColumn(capabilities, columnHolder);
break;
default:
log.warn("Unknown column type[%s].", capabilities.asTypeString());
@ -339,19 +341,21 @@ public class SegmentAnalyzer
private ColumnAnalysis analyzeComplexColumn(
@Nullable final ColumnCapabilities capabilities,
@Nullable final ColumnHolder columnHolder,
final String typeName
@Nullable final ColumnHolder columnHolder
)
{
final TypeSignature<ValueType> typeSignature = capabilities == null ? ColumnType.UNKNOWN_COMPLEX : capabilities;
final String typeName = typeSignature.getComplexTypeName();
// serialize using asTypeString (which is also used for JSON so can easily round-trip complex type info back into ColumnType)
final String serdeTypeName = ColumnType.ofComplex(typeName).asTypeString();
final String serdeTypeName = typeSignature.asTypeString();
try (final ComplexColumn complexColumn = columnHolder != null ? (ComplexColumn) columnHolder.getColumn() : null) {
final boolean hasMultipleValues = capabilities != null && capabilities.hasMultipleValues().isTrue();
final boolean hasNulls = capabilities != null && capabilities.hasNulls().isMaybeTrue();
long size = 0;
if (analyzingSize() && complexColumn != null) {
final ComplexMetricSerde serde = ComplexMetrics.getSerdeForType(typeName);
final ComplexMetricSerde serde = typeName == null ? null : ComplexMetrics.getSerdeForType(typeName);
if (serde == null) {
return ColumnAnalysis.error(StringUtils.format("unknown_complex_%s", typeName));
}

23
processing/src/main/java/org/apache/druid/segment/QueryableIndexStorageAdapter.java
View File

@ -36,7 +36,6 @@ import org.apache.druid.segment.column.BaseColumn;
import org.apache.druid.segment.column.BitmapIndex;
import org.apache.druid.segment.column.ColumnCapabilities;
import org.apache.druid.segment.column.ColumnHolder;
import org.apache.druid.segment.column.ComplexColumn;
import org.apache.druid.segment.column.DictionaryEncodedColumn;
import org.apache.druid.segment.column.NumericColumn;
import org.apache.druid.segment.data.Indexed;
@ -172,28 +171,6 @@ public class QueryableIndexStorageAdapter implements StorageAdapter
return getColumnCapabilities(index, column);
}
@Override
@Nullable
public String getColumnTypeName(String columnName)
{
final ColumnHolder columnHolder = index.getColumnHolder(columnName);
if (columnHolder == null) {
return null;
}
try (final BaseColumn col = columnHolder.getColumn()) {
if (col instanceof ComplexColumn) {
return ((ComplexColumn) col).getTypeName();
} else {
return columnHolder.getCapabilities().asTypeString();
}
}
catch (IOException e) {
throw new UncheckedIOException(e);
}
}
@Override
public DateTime getMaxIngestedEventTime()
{

8
processing/src/main/java/org/apache/druid/segment/RowBasedStorageAdapter.java
View File

@ -120,14 +120,6 @@ public class RowBasedStorageAdapter<RowType> implements StorageAdapter
return RowBasedColumnSelectorFactory.getColumnCapabilities(rowSignature, column);
}
@Nullable
@Override
public String getColumnTypeName(String column)
{
final ColumnCapabilities columnCapabilities = getColumnCapabilities(column);
return columnCapabilities != null ? columnCapabilities.asTypeString() : null;
}
@Override
public int getNumRows()
{

7
processing/src/main/java/org/apache/druid/segment/StorageAdapter.java
View File

@ -66,13 +66,6 @@ public interface StorageAdapter extends CursorFactory, ColumnInspector
@Nullable
ColumnCapabilities getColumnCapabilities(String column);
/**
* Like {@link ColumnCapabilities#getType()}, but may return a more descriptive string for complex columns.
* @param column column name
* @return type name
*/
@Nullable
String getColumnTypeName(String column);
int getNumRows();
DateTime getMaxIngestedEventTime();
Metadata getMetadata();

5
processing/src/main/java/org/apache/druid/segment/column/ColumnDescriptor.java
View File

@ -26,11 +26,9 @@ import org.apache.druid.java.util.common.IAE;
import org.apache.druid.java.util.common.io.smoosh.FileSmoosher;
import org.apache.druid.java.util.common.io.smoosh.SmooshedFileMapper;
import org.apache.druid.segment.serde.ColumnPartSerde;
import org.apache.druid.segment.serde.ComplexColumnPartSerde;
import org.apache.druid.segment.serde.Serializer;
import javax.annotation.Nullable;
import java.io.IOException;
import java.nio.ByteBuffer;
import java.nio.channels.WritableByteChannel;
@ -106,9 +104,6 @@ public class ColumnDescriptor implements Serializer
.setFileMapper(smooshedFiles);
for (ColumnPartSerde part : parts) {
if (part instanceof ComplexColumnPartSerde) {
builder.setComplexTypeName(((ComplexColumnPartSerde) part).getTypeName());
}
part.getDeserializer().read(buffer, builder, columnConfig);
}

15
processing/src/main/java/org/apache/druid/segment/incremental/IncrementalIndexStorageAdapter.java
View File

@ -239,21 +239,6 @@ public class IncrementalIndexStorageAdapter implements StorageAdapter
);
}
@Override
public String getColumnTypeName(String column)
{
final String metricType = index.getMetricType(column);
if (metricType != null) {
return metricType;
}
ColumnCapabilities columnCapabilities = getColumnCapabilities(column);
if (columnCapabilities != null) {
return columnCapabilities.asTypeString();
} else {
return null;
}
}
@Override
public DateTime getMaxIngestedEventTime()
{

15
processing/src/main/java/org/apache/druid/segment/join/HashJoinSegmentStorageAdapter.java
View File

@ -188,21 +188,6 @@ public class HashJoinSegmentStorageAdapter implements StorageAdapter
}
}
@Nullable
@Override
public String getColumnTypeName(String column)
{
final Optional<JoinableClause> maybeClause = getClauseForColumn(column);
if (maybeClause.isPresent()) {
final JoinableClause clause = maybeClause.get();
final ColumnCapabilities capabilities = clause.getJoinable().getColumnCapabilities(clause.unprefix(column));
return capabilities != null ? capabilities.asTypeString() : null;
} else {
return baseAdapter.getColumnTypeName(column);
}
}
@Override
public int getNumRows()
{

12
processing/src/main/java/org/apache/druid/segment/serde/ComplexColumnPartSerde.java
View File

@ -78,12 +78,14 @@ public class ComplexColumnPartSerde implements ColumnPartSerde
public Deserializer getDeserializer()
{
return (buffer, builder, columnConfig) -> {
// we don't currently know if complex column can have nulls (or can be multi-valued, but not making that change
// since it isn't supported anywhere in the query engines)
// longer term this needs to be captured by making the serde provide this information, and then this should
// no longer be set to true but rather the actual values
builder.setHasNulls(ColumnCapabilities.Capable.TRUE);
builder.setComplexTypeName(typeName);
if (serde != null) {
// we don't currently know if complex column can have nulls (or can be multi-valued, but not making that change
// since it isn't supported anywhere in the query engines)
// longer term this needs to be captured by making the serde provide this information, and then this should
// no longer be set to true but rather the actual values
builder.setHasNulls(ColumnCapabilities.Capable.TRUE);
serde.deserializeColumn(buffer, builder, columnConfig);
}
};

12
processing/src/main/java/org/apache/druid/segment/serde/ComplexMetrics.java
View File

@ -69,4 +69,16 @@ public class ComplexMetrics
}
});
}
/**
* Unregister a serde name -> ComplexMetricSerde mapping.
*
* If the specified serde key string is not in use, does nothing.
*
* Only expected to be used in tests.
*/
public static void unregisterSerde(String type)
{
COMPLEX_SERIALIZERS.remove(type);
}
}

56
processing/src/test/java/org/apache/druid/query/metadata/SegmentAnalyzerTest.java
View File

@ -42,7 +42,6 @@ import org.apache.druid.query.metadata.metadata.SegmentMetadataQuery;
import org.apache.druid.query.spec.LegacySegmentSpec;
import org.apache.druid.segment.ColumnSelectorFactory;
import org.apache.druid.segment.IncrementalIndexSegment;
import org.apache.druid.segment.QueryableIndex;
import org.apache.druid.segment.QueryableIndexSegment;
import org.apache.druid.segment.Segment;
import org.apache.druid.segment.TestIndex;
@ -59,9 +58,12 @@ import org.apache.druid.segment.serde.ComplexMetrics;
import org.apache.druid.testing.InitializedNullHandlingTest;
import org.apache.druid.timeline.SegmentId;
import org.junit.Assert;
import org.junit.Rule;
import org.junit.Test;
import org.junit.rules.TemporaryFolder;
import javax.annotation.Nullable;
import java.io.File;
import java.io.IOException;
import java.net.URL;
import java.nio.ByteBuffer;
@ -77,6 +79,9 @@ public class SegmentAnalyzerTest extends InitializedNullHandlingTest
private static final EnumSet<SegmentMetadataQuery.AnalysisType> EMPTY_ANALYSES =
EnumSet.noneOf(SegmentMetadataQuery.AnalysisType.class);
@Rule
public final TemporaryFolder temporaryFolder = new TemporaryFolder();
@Test
public void testIncrementalWorks()
{
@ -282,20 +287,43 @@ public class SegmentAnalyzerTest extends InitializedNullHandlingTest
.setMaxRowCount(10000)
.build();
IncrementalIndex incrementalIndex = TestIndex.loadIncrementalIndex(retVal, source);
QueryableIndex queryableIndex = TestIndex.persistRealtimeAndLoadMMapped(incrementalIndex);
SegmentAnalyzer analyzer = new SegmentAnalyzer(EnumSet.of(SegmentMetadataQuery.AnalysisType.SIZE));
QueryableIndexSegment segment = new QueryableIndexSegment(
queryableIndex,
SegmentId.dummy("ds")
);
Map<String, ColumnAnalysis> analyses = analyzer.analyze(segment);
ColumnAnalysis invalidColumnAnalysis = analyses.get(invalid_aggregator);
Assert.assertTrue(invalidColumnAnalysis.isError());
// Run a segment metadata query also to verify it doesn't break
final List<SegmentAnalysis> results = getSegmentAnalysises(segment, EnumSet.of(SegmentMetadataQuery.AnalysisType.SIZE));
for (SegmentAnalysis result : results) {
Assert.assertTrue(result.getColumns().get(invalid_aggregator).isError());
// Analyze the in-memory segment.
{
SegmentAnalyzer analyzer = new SegmentAnalyzer(EnumSet.of(SegmentMetadataQuery.AnalysisType.SIZE));
IncrementalIndexSegment segment = new IncrementalIndexSegment(incrementalIndex, SegmentId.dummy("ds"));
Map<String, ColumnAnalysis> analyses = analyzer.analyze(segment);
ColumnAnalysis columnAnalysis = analyses.get(invalid_aggregator);
Assert.assertFalse(columnAnalysis.isError());
Assert.assertEquals("COMPLEX<invalid_complex_column_type>", columnAnalysis.getType());
}
// Persist the index.
final File segmentFile = TestIndex.INDEX_MERGER.persist(
incrementalIndex,
temporaryFolder.newFolder(),
TestIndex.INDEX_SPEC,
null
);
// Unload the complex serde, then analyze the persisted segment.
ComplexMetrics.unregisterSerde(InvalidAggregatorFactory.TYPE);
{
SegmentAnalyzer analyzer = new SegmentAnalyzer(EnumSet.of(SegmentMetadataQuery.AnalysisType.SIZE));
QueryableIndexSegment segment = new QueryableIndexSegment(
TestIndex.INDEX_IO.loadIndex(segmentFile),
SegmentId.dummy("ds")
);
Map<String, ColumnAnalysis> analyses = analyzer.analyze(segment);
ColumnAnalysis invalidColumnAnalysis = analyses.get(invalid_aggregator);
Assert.assertTrue(invalidColumnAnalysis.isError());
Assert.assertEquals("error:unknown_complex_invalid_complex_column_type", invalidColumnAnalysis.getErrorMessage());
// Run a segment metadata query also to verify it doesn't break
final List<SegmentAnalysis> results = getSegmentAnalysises(segment, EnumSet.of(SegmentMetadataQuery.AnalysisType.SIZE));
for (SegmentAnalysis result : results) {
Assert.assertTrue(result.getColumns().get(invalid_aggregator).isError());
}
}
}

7
processing/src/test/java/org/apache/druid/query/topn/TopNMetricSpecOptimizationsTest.java
View File

@ -302,13 +302,6 @@ public class TopNMetricSpecOptimizationsTest
return null;
}
@Nullable
@Override
public String getColumnTypeName(String column)
{
return null;
}
@Override
public int getNumRows()
{

22
processing/src/test/java/org/apache/druid/segment/RowBasedStorageAdapterTest.java
View File

@ -198,7 +198,10 @@ public class RowBasedStorageAdapterTest
if (valueType == null || valueType == ValueType.COMPLEX) {
return i -> null;
} else {
return i -> DimensionHandlerUtils.convertObjectToType(i, ROW_SIGNATURE.getColumnType(columnName).orElse(null));
return i -> DimensionHandlerUtils.convertObjectToType(
i,
ROW_SIGNATURE.getColumnType(columnName).orElse(null)
);
}
}
}
@ -399,26 +402,23 @@ public class RowBasedStorageAdapterTest
}
@Test
public void test_getColumnTypeName()
public void test_getColumnTypeString()
{
final RowBasedStorageAdapter<Integer> adapter = createIntAdapter(0, 1, 2);
for (String columnName : ROW_SIGNATURE.getColumnNames()) {
if (UNKNOWN_TYPE_NAME.equals(columnName)) {
Assert.assertNull(columnName, adapter.getColumnTypeName(columnName));
Assert.assertNull(columnName, adapter.getColumnCapabilities(columnName));
} else {
Assert.assertEquals(columnName, ValueType.valueOf(columnName).name(), adapter.getColumnTypeName(columnName));
Assert.assertEquals(
columnName,
ValueType.valueOf(columnName).name(),
adapter.getColumnCapabilities(columnName).asTypeString()
);
}
}
}
@Test
public void test_getColumnTypeName_nonexistent()
{
final RowBasedStorageAdapter<Integer> adapter = createIntAdapter(0, 1, 2);
Assert.assertNull(adapter.getColumnTypeName("nonexistent"));
}
@Test
public void test_getNumRows()
{

27
processing/src/test/java/org/apache/druid/segment/join/HashJoinSegmentStorageAdapterTest.java
View File

@ -241,31 +241,30 @@ public class HashJoinSegmentStorageAdapterTest extends BaseHashJoinSegmentStorag
}
@Test
public void test_getColumnTypeName_factToCountryFactColumn()
{
Assert.assertEquals("hyperUnique", makeFactToCountrySegment().getColumnTypeName("channel_uniques"));
}
@Test
public void test_getColumnTypeName_factToCountryJoinColumn()
public void test_getColumnCapabilities_complexTypeName_factToCountryFactColumn()
{
Assert.assertEquals(
"STRING",
makeFactToCountrySegment().getColumnTypeName(FACT_TO_COUNTRY_ON_ISO_CODE_PREFIX + "countryName")
"hyperUnique",
makeFactToCountrySegment().getColumnCapabilities("channel_uniques").getComplexTypeName()
);
}
@Test
public void test_getColumnTypeName_factToCountryNonexistentFactColumn()
public void test_getColumnCapabilities_typeString_factToCountryFactColumn()
{
Assert.assertNull(makeFactToCountrySegment().getColumnTypeName("nonexistent"));
Assert.assertEquals(
"COMPLEX<hyperUnique>",
makeFactToCountrySegment().getColumnCapabilities("channel_uniques").asTypeString()
);
}
@Test
public void test_getColumnTypeName_factToCountryNonexistentJoinColumn()
public void test_getColumnCapabilities_typeString_factToCountryJoinColumn()
{
Assert.assertNull(
makeFactToCountrySegment().getColumnTypeName(FACT_TO_COUNTRY_ON_ISO_CODE_PREFIX + "nonexistent")
Assert.assertEquals(
"STRING",
makeFactToCountrySegment().getColumnCapabilities(FACT_TO_COUNTRY_ON_ISO_CODE_PREFIX + "countryName")
.asTypeString()
);
}

8
server/src/test/java/org/apache/druid/server/coordination/ServerManagerTest.java
View File

@ -103,7 +103,6 @@ import org.junit.Test;
import org.junit.rules.ExpectedException;
import javax.annotation.Nullable;
import java.io.IOException;
import java.util.ArrayList;
import java.util.Arrays;
@ -912,13 +911,6 @@ public class ServerManagerTest
return null;
}
@Nullable
@Override
public String getColumnTypeName(String column)
{
return null;
}
@Override
public int getNumRows()
{