Merge branch 'master' into onheap-incremental-index

examples/config/_common/common.runtime.properties

@@ -14,6 +14,10 @@ druid.metadata.storage.connector.password=diurd
 druid.storage.type=local
 druid.storage.storage.storageDirectory=/tmp/druid/localStorage
 
+# Cache (we use a simple 10mb heap-based local cache on the broker)
+druid.cache.type=local
+druid.cache.sizeInBytes=10000000
+
 # Indexing service discovery
 druid.selectors.indexing.serviceName=overlord
 

examples/config/broker/runtime.properties

@@ -1,6 +1,9 @@
 druid.host=localhost
-druid.service=broker
 druid.port=8080
+druid.service=broker
+
+druid.broker.cache.useCache=true
+druid.broker.cache.populateCache=true
 
 # Bump these up only for faster nested groupBy
 druid.processing.buffer.sizeBytes=100000000

examples/config/coordinator/runtime.properties

@@ -1,5 +1,7 @@
 druid.host=localhost
-druid.service=coordinator
 druid.port=8082
+druid.service=coordinator
 
+# The coordinator begins assignment operations after the start delay.
+# We override the default here to start things up faster for examples.
 druid.coordinator.startDelay=PT70s

examples/config/historical/runtime.properties

@@ -1,8 +1,9 @@
 druid.host=localhost
-druid.service=historical
 druid.port=8081
+druid.service=historical
 
-# Change these to make Druid faster
+# We can only 1 scan segment in parallel with these configs.
+# Our intermediate buffer is also very small so longer topNs will be slow.
 druid.processing.buffer.sizeBytes=100000000
 druid.processing.numThreads=1
 

examples/config/overlord/runtime.properties

@@ -2,6 +2,7 @@ druid.host=localhost
 druid.port=8080
 druid.service=overlord
 
+# Run the overlord in local mode with a single peon to execute tasks
 druid.indexer.queue.startDelay=PT0M
 druid.indexer.runner.javaOpts="-server -Xmx256m"
 druid.indexer.fork.property.druid.processing.numThreads=1

examples/config/realtime/runtime.properties

@@ -1,10 +1,12 @@
 druid.host=localhost
-druid.service=realtime
 druid.port=8083
+druid.service=realtime
 
-# Change this config to metadata to hand off to the rest of the Druid cluster
+# Change this config to 'metadata' to hand off to the rest of the Druid cluster
 druid.publish.type=noop
 
+# We can only 1 scan segment in parallel with these configs.
+# Our intermediate buffer is also very small so longer topNs will be slow.
 druid.processing.buffer.sizeBytes=100000000
 druid.processing.numThreads=1
 

indexing-hadoop/src/main/java/io/druid/indexer/HadoopDruidIndexerJob.java

@@ -19,6 +19,7 @@
 
 package io.druid.indexer;
 
+import com.google.common.base.Preconditions;
 import com.google.common.collect.Lists;
 import com.google.inject.Inject;
 import com.metamx.common.logger.Logger;
@@ -45,6 +46,11 @@ public class HadoopDruidIndexerJob implements Jobby
     config.verify();
     this.config = config;
 
+    Preconditions.checkArgument(
+        !config.isUpdaterJobSpecSet() || handler != null,
+        "MetadataStorageUpdaterJobHandler must not be null if ioConfig.metadataUpdateSpec is specified."
+    );
+
     if (config.isUpdaterJobSpecSet()) {
       metadataStorageUpdaterJob = new MetadataStorageUpdaterJob(
           config,

indexing-service/src/main/java/io/druid/indexing/common/task/HadoopIndexTask.java

@@ -290,10 +290,16 @@ public class HadoopIndexTask extends AbstractTask
               .withTuningConfig(theSchema.getTuningConfig().withVersion(version))
       );
 
-      HadoopDruidIndexerJob job = new HadoopDruidIndexerJob(
-          config,
-          injector.getInstance(MetadataStorageUpdaterJobHandler.class)
-      );
+      // MetadataStorageUpdaterJobHandler is only needed when running standalone without indexing service
+      // In that case the whatever runs the Hadoop Index Task must ensure MetadataStorageUpdaterJobHandler
+      // can be injected based on the configuration given in config.getSchema().getIOConfig().getMetadataUpdateSpec()
+      final MetadataStorageUpdaterJobHandler maybeHandler;
+      if (config.isUpdaterJobSpecSet()) {
+        maybeHandler = injector.getInstance(MetadataStorageUpdaterJobHandler.class);
+      } else {
+        maybeHandler = null;
+      }
+      HadoopDruidIndexerJob job = new HadoopDruidIndexerJob(config, maybeHandler);
 
       log.info("Starting a hadoop index generator job...");
       if (job.run()) {

indexing-service/src/main/java/io/druid/indexing/overlord/ForkingTaskRunner.java

@@ -234,7 +234,7 @@ public class ForkingTaskRunner implements TaskRunner, TaskLogStreamer
                             log.info("Logging task %s output to: %s", task.getId(), logFile);
                             boolean runFailed = true;
 
-                            try (final OutputStream toLogfile = Files.newOutputStreamSupplier(logFile).getOutput()) {
+                            try (final OutputStream toLogfile = Files.asByteSink(logFile).openBufferedStream()) {
                               ByteStreams.copy(processHolder.process.getInputStream(), toLogfile);
                               final int statusCode = processHolder.process.waitFor();
                               log.info("Process exited with status[%d] for task: %s", statusCode, task.getId());

server/src/main/java/io/druid/client/cache/CacheConfig.java

@@ -31,10 +31,10 @@ public class CacheConfig
   public static final String POPULATE_CACHE = "populateCache";
 
   @JsonProperty
-  private boolean useCache = true;
+  private boolean useCache = false;
 
   @JsonProperty
-  private boolean populateCache = true;
+  private boolean populateCache = false;
 
   @JsonProperty
   private List<String> unCacheable = Arrays.asList(Query.GROUP_BY, Query.SELECT);

server/src/test/java/io/druid/client/CachingClusteredClientTest.java

@@ -1902,6 +1902,18 @@ public class CachingClusteredClientTest
         jsonMapper,
         new CacheConfig()
         {
+          @Override
+          public boolean isPopulateCache()
+          {
+            return true;
+          }
+
+          @Override
+          public boolean isUseCache()
+          {
+            return true;
+          }
+
           @Override
           public boolean isQueryCacheable(Query query)
           {

server/src/test/java/io/druid/client/CachingQueryRunnerTest.java

@@ -82,7 +82,7 @@ public class CachingQueryRunnerTest
   @Test
   public void testCloseAndPopulate() throws Exception
   {
-    Iterable<Result<TopNResultValue>> expectedRes = makeTopNResults(false,objects);
+    Iterable<Result<TopNResultValue>> expectedRes = makeTopNResults(false, objects);
     final TopNQueryBuilder builder = new TopNQueryBuilder()
         .dataSource("ds")
         .dimension("top_dim")
@@ -130,7 +130,19 @@ public class CachingQueryRunnerTest
           }
         },
         new CacheConfig()
+        {
+          @Override
+          public boolean isPopulateCache()
+          {
+            return true;
+          }
 
+          @Override
+          public boolean isUseCache()
+          {
+            return true;
+          }
+        }
     );
 
     TopNQuery query = builder.build();
@@ -141,7 +153,7 @@ public class CachingQueryRunnerTest
         cacheStrategy.computeCacheKey(query)
     );
 
-    HashMap<String,Object> context = new HashMap<String, Object>();
+    HashMap<String, Object> context = new HashMap<String, Object>();
     Sequence res = runner.run(query, context);
     // base sequence is not closed yet
     Assert.assertFalse("sequence must not be closed", closable.isClosed());
@@ -220,9 +232,22 @@ public class CachingQueryRunnerTest
           }
         },
         new CacheConfig()
+        {
+          @Override
+          public boolean isPopulateCache()
+          {
+            return true;
+          }
+
+          @Override
+          public boolean isUseCache()
+          {
+            return true;
+          }
+        }
 
     );
-    HashMap<String,Object> context = new HashMap<String, Object>();
+    HashMap<String, Object> context = new HashMap<String, Object>();
     List<Object> results = Sequences.toList(runner.run(query, context), new ArrayList());
     Assert.assertEquals(expectedResults, results);
   }

services/src/main/java/io/druid/cli/CliBroker.java

@@ -90,7 +90,7 @@ public class CliBroker extends ServerRunnable
             binder.bind(TimelineServerView.class).to(BrokerServerView.class).in(LazySingleton.class);
 
             binder.bind(Cache.class).toProvider(CacheProvider.class).in(ManageLifecycle.class);
-            JsonConfigProvider.bind(binder, "druid.broker.cache", CacheProvider.class);
+            JsonConfigProvider.bind(binder, "druid.cache", CacheProvider.class);
             JsonConfigProvider.bind(binder, "druid.broker.cache", CacheConfig.class);
             JsonConfigProvider.bind(binder, "druid.broker.select", TierSelectorStrategy.class);
             JsonConfigProvider.bind(binder, "druid.broker.select.tier.custom", CustomTierSelectorStrategyConfig.class);

services/src/main/java/io/druid/cli/CliHistorical.java

@@ -88,7 +88,7 @@ public class CliHistorical extends ServerRunnable
             LifecycleModule.register(binder, ZkCoordinator.class);            
 
             binder.bind(Cache.class).toProvider(CacheProvider.class).in(ManageLifecycle.class);
-            JsonConfigProvider.bind(binder, "druid.historical.cache", CacheProvider.class);
+            JsonConfigProvider.bind(binder, "druid.cache", CacheProvider.class);
             JsonConfigProvider.bind(binder, "druid.historical.cache", CacheConfig.class);
             MetricsModule.register(binder, CacheMonitor.class);
           }