Apache
/
druid
mirror of https://github.com/apache/druid.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Spotbugs: RC_REF_COMPARISON_BAD_PRACTICE_BOOLEAN (#8076) 

* Spotbugs: RC_REF_COMPARISON_BAD_PRACTICE_BOOLEAN

* Use Objects instead
This commit is contained in:
Fokko Driesprong 2019-07-25 01:17:02 +02:00 committed by Himanshu
parent c87b47e0fa
commit 714a2726a7
3 changed files with 2 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
codestyle/spotbugs-exclude.xml
View File

@ -75,7 +75,6 @@
<Bug pattern="OS_OPEN_STREAM"/> <Bug pattern="OS_OPEN_STREAM"/>
<Bug pattern="RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE"/> <Bug pattern="RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE"/>
<Bug pattern="RCN_REDUNDANT_NULLCHECK_WOULD_HAVE_BEEN_A_NPE"/> <Bug pattern="RCN_REDUNDANT_NULLCHECK_WOULD_HAVE_BEEN_A_NPE"/>
<Bug pattern="RC_REF_COMPARISON_BAD_PRACTICE_BOOLEAN"/>
<Bug pattern="REC_CATCH_EXCEPTION"/> <Bug pattern="REC_CATCH_EXCEPTION"/>
<Bug pattern="RV_RETURN_VALUE_IGNORED_BAD_PRACTICE"/> <Bug pattern="RV_RETURN_VALUE_IGNORED_BAD_PRACTICE"/>
<Bug pattern="RV_RETURN_VALUE_IGNORED_NO_SIDE_EFFECT"/> <Bug pattern="RV_RETURN_VALUE_IGNORED_NO_SIDE_EFFECT"/>

2
processing/src/main/java/org/apache/druid/query/metadata/metadata/SegmentAnalysis.java
View File

@ -159,7 +159,7 @@ public class SegmentAnalysis implements Comparable<SegmentAnalysis>
SegmentAnalysis that = (SegmentAnalysis) o; SegmentAnalysis that = (SegmentAnalysis) o;
return size == that.size && return size == that.size &&
numRows == that.numRows && numRows == that.numRows &&
rollup == that.rollup && Objects.equals(rollup, that.rollup) &&
Objects.equals(id, that.id) && Objects.equals(id, that.id) &&
Objects.equals(interval, that.interval) && Objects.equals(interval, that.interval) &&
Objects.equals(columns, that.columns) && Objects.equals(columns, that.columns) &&

2
processing/src/main/java/org/apache/druid/query/scan/ScanQuery.java
View File

@ -312,7 +312,7 @@ public class ScanQuery extends BaseQuery<ScanResultValue>
final ScanQuery scanQuery = (ScanQuery) o; final ScanQuery scanQuery = (ScanQuery) o;
return batchSize == scanQuery.batchSize && return batchSize == scanQuery.batchSize &&
limit == scanQuery.limit && limit == scanQuery.limit &&
legacy == scanQuery.legacy && Objects.equals(legacy, scanQuery.legacy) &&
Objects.equals(virtualColumns, scanQuery.virtualColumns) && Objects.equals(virtualColumns, scanQuery.virtualColumns) &&
Objects.equals(resultFormat, scanQuery.resultFormat) && Objects.equals(resultFormat, scanQuery.resultFormat) &&
Objects.equals(dimFilter, scanQuery.dimFilter) && Objects.equals(dimFilter, scanQuery.dimFilter) &&