diff --git a/.github/pull_request_template.md b/.github/pull_request_template.md index 6bb2c5dfdea..79623f11a98 100644 --- a/.github/pull_request_template.md +++ b/.github/pull_request_template.md @@ -42,6 +42,7 @@ This PR has: - [ ] using the [concurrency checklist](https://github.com/apache/incubator-druid/blob/master/dev/code-review/concurrency.md) (Remove this item if the PR doesn't have any relation to concurrency.) - [ ] added documentation for new or modified features or behaviors. - [ ] added Javadocs for most classes and all non-trivial methods. Linked related entities via Javadoc links. +- [ ] added or updated version, license, or notice information in [licenses.yaml](https://github.com/apache/incubator-druid/blob/master/licenses.yaml) - [ ] added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader. - [ ] added unit tests or modified existing tests to cover new code paths. - [ ] added integration tests. diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index 3a5c28599fd..2201a0cdbf1 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -36,6 +36,9 @@ When submitting a pull request (PR), please use the following guidelines: - Do not use author tags/information in the code. - Try to keep pull requests short and submit separate ones for unrelated features, but feel free to combine simple bugfixes/tests into one pull request. +- If you are adding or updating a dependency, be sure to update the version, license, or notice information in + [licenses.yaml](https://github.com/apache/incubator-druid/blob/master/licenses.yaml) as appropriate to help ease + LICENSE and NOTICE management for ASF releases. You can find more developers' resources in [`dev/`](dev) directory.