mirror of https://github.com/apache/druid.git
1) Cleanup TODO comments
This commit is contained in:
cheddar
parent
545b489093
commit
7370b0f2fc
|
|
@ -98,7 +98,7 @@ public class RealtimeIndexTask extends AbstractTask
|
|||
@JsonProperty("id") String id,
|
||||
@JsonProperty("schema") Schema schema,
|
||||
@JsonProperty("firehose") FirehoseFactory firehoseFactory,
|
||||
@JsonProperty("fireDepartmentConfig") FireDepartmentConfig fireDepartmentConfig, // TODO rename?
|
||||
@JsonProperty("fireDepartmentConfig") FireDepartmentConfig fireDepartmentConfig,
|
||||
@JsonProperty("windowPeriod") Period windowPeriod,
|
||||
@JsonProperty("segmentGranularity") IndexGranularity segmentGranularity,
|
||||
@JsonProperty("minTime") DateTime minTime
|
||||
|
|
@ -178,8 +178,8 @@ public class RealtimeIndexTask extends AbstractTask
|
|||
firehose = new GracefulShutdownFirehose(wrappedFirehose, segmentGranularity, windowPeriod);
|
||||
}
|
||||
|
||||
// TODO -- Take PlumberSchool in constructor (although that will need jackson injectables for stuff like
|
||||
// TODO -- the ServerView, which seems kind of odd?)
|
||||
// It would be nice to get the PlumberSchool in the constructor. Although that will need jackson injectables for
|
||||
// stuff like the ServerView, which seems kind of odd? Perhaps revisit this when Guice has been introduced.
|
||||
final RealtimePlumberSchool realtimePlumberSchool = new RealtimePlumberSchool(
|
||||
windowPeriod,
|
||||
new File(toolbox.getTaskWorkDir(), "persist"),
|
||||
|
|
@ -188,10 +188,9 @@ public class RealtimeIndexTask extends AbstractTask
|
|||
|
||||
final SegmentPublisher segmentPublisher = new TaskActionSegmentPublisher(this, toolbox);
|
||||
|
||||
// TODO -- We're adding stuff to talk to the coordinator in various places in the plumber, and may
|
||||
// TODO -- want to be more robust to coordinator downtime (currently we'll block/throw in whatever
|
||||
// TODO -- thread triggered the coordinator behavior, which will typically be either the main
|
||||
// TODO -- data processing loop or the persist thread)
|
||||
// NOTE: We talk to the coordinator in various places in the plumber and we could be more robust to issues
|
||||
// with the coordinator. Right now, we'll block/throw in whatever thread triggered the coordinator behavior,
|
||||
// which will typically be either the main data processing loop or the persist thread.
|
||||
|
||||
// Wrap default SegmentAnnouncer such that we unlock intervals as we unannounce segments
|
||||
final SegmentAnnouncer lockingSegmentAnnouncer = new SegmentAnnouncer()
|
||||
|
|
|
|||
|
|
@ -56,7 +56,7 @@ public interface TaskStorage
|
|||
* Returns task as stored in the storage facility. If the task ID does not exist, this will return an
|
||||
* absentee Optional.
|
||||
*
|
||||
* TODO -- This method probably wants to be combined with {@link #getStatus}.
|
||||
* NOTE: This method really feels like it should be combined with {@link #getStatus}. Expect that in the future.
|
||||
*/
|
||||
public Optional<Task> getTask(String taskid);
|
||||
|
||||
|
|
|
|||
|
|
@ -143,12 +143,13 @@ public class TaskStorageQueryAdapter
|
|||
* Returns all segments created by descendants for a particular task that stayed within the same task group. Includes
|
||||
* that task, plus any tasks it spawned, and so on. Does not include spawned tasks that ended up in a different task
|
||||
* group. Does not include this task's parents or siblings.
|
||||
*
|
||||
* This method is useful when you want to figure out all of the things a single task spawned. It does pose issues
|
||||
* with the result set perhaps growing boundlessly and we do not do anything to protect against that. Use at your
|
||||
* own risk and know that at some point, we might adjust this to actually enforce some sort of limits.
|
||||
*/
|
||||
public Set<DataSegment> getSameGroupNewSegments(final String taskid)
|
||||
{
|
||||
// TODO: This is useful for regular index tasks (so we know what was published), but
|
||||
// TODO: for long-lived index tasks the list can get out of hand. We may want a limit.
|
||||
|
||||
final Optional<Task> taskOptional = storage.getTask(taskid);
|
||||
final Set<DataSegment> segments = Sets.newHashSet();
|
||||
final List<Task> nextTasks = Lists.newArrayList();
|
||||
|
|
|
|||
|
|
@ -297,8 +297,7 @@ public class IndexerCoordinatorNode extends QueryableNode<IndexerCoordinatorNode
|
|||
);
|
||||
staticContext.setBaseResource(resourceCollection);
|
||||
|
||||
// TODO -- Need a QueryServlet and some kind of QuerySegmentWalker if we want to support querying tasks
|
||||
// TODO -- (e.g. for realtime) in local mode
|
||||
// If we want to support querying tasks (e.g. for realtime in local mode), we need a QueryServlet here.
|
||||
|
||||
final Context root = new Context(server, "/", Context.SESSIONS);
|
||||
root.addServlet(new ServletHolder(new StatusServlet()), "/status");
|
||||
|
|
|
|||
|
|
@ -177,7 +177,7 @@ public class IndexerCoordinatorResource
|
|||
}
|
||||
|
||||
// Legacy endpoint
|
||||
// TODO Remove
|
||||
// TODO remove
|
||||
@Deprecated
|
||||
@GET
|
||||
@Path("/status/{taskid}")
|
||||
|
|
@ -239,7 +239,9 @@ public class IndexerCoordinatorResource
|
|||
{
|
||||
final Map<String, Object> retMap;
|
||||
|
||||
// TODO make sure this worker is supposed to be running this task (attempt id? token?)
|
||||
// It would be great to verify that this worker is actually supposed to be running the task before
|
||||
// actually doing the task. Some ideas for how that could be done would be using some sort of attempt_id
|
||||
// or token that gets passed around.
|
||||
|
||||
try {
|
||||
final T ret = taskActionClient.submit(holder.getAction());
|
||||
|
|
|
|||
|
|
@ -372,7 +372,8 @@ public class InfoResource
|
|||
@QueryParam("interval") final String interval
|
||||
)
|
||||
{
|
||||
// TODO: will likely be all rewritten once Guice introduced
|
||||
// This is weird enough to have warranted some sort of T0D0 comment at one point, but it will likely be all
|
||||
// rewritten once Guice introduced, and that's the brunt of the information that was in the original T0D0 too.
|
||||
if (indexingServiceClient == null) {
|
||||
return Response.status(Response.Status.OK).entity(ImmutableMap.of("error", "no indexing service found")).build();
|
||||
}
|
||||
|
|
|
|||
|
|
@ -96,7 +96,7 @@ public class TimeseriesQueryEngine
|
|||
@Override
|
||||
public void cleanup(Iterator<Result<TimeseriesResultValue>> toClean)
|
||||
{
|
||||
// TODO: Let's fix this to actually use Sequences for the closing of stuff
|
||||
// https://github.com/metamx/druid/issues/128
|
||||
while (toClean.hasNext()) {
|
||||
toClean.next();
|
||||
}
|
||||
|
|
|
|||
Loading…
Reference in New Issue