Apache
/
druid
mirror of https://github.com/apache/druid.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

as per @itaiy suggested will close then try to connect. (#3669) 

* as per @itaiy suggested will close then try to connect.

* use close instead of flush

* git fix comments

* break the loop in case of interrupted
This commit is contained in:
Slim 2016-12-13 10:20:28 -08:00 committed by Nishant
parent 469ab21091
commit 7b18fb79e0
1 changed files with 10 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
extensions-contrib/graphite-emitter/src/main/java/io/druid/emitter/graphite/GraphiteEmitter.java
View File

@ -136,16 +136,14 @@ public class GraphiteEmitter implements Emitter
private class ConsumerRunnable implements Runnable private class ConsumerRunnable implements Runnable
{ {
private PickledGraphite pickledGraphite = new PickledGraphite(
graphiteEmitterConfig.getHostname(),
graphiteEmitterConfig.getPort(),
graphiteEmitterConfig.getBatchSize()
);
@Override @Override
public void run() public void run()
{ {
try { try (PickledGraphite pickledGraphite = new PickledGraphite(
graphiteEmitterConfig.getHostname(),
graphiteEmitterConfig.getPort(),
graphiteEmitterConfig.getBatchSize()
)) {
if (!pickledGraphite.isConnected()) { if (!pickledGraphite.isConnected()) {
log.info("trying to connect to graphite server"); log.info("trying to connect to graphite server");
pickledGraphite.connect(); pickledGraphite.connect();
@ -174,12 +172,16 @@ public class GraphiteEmitter implements Emitter
log.error(e, e.getMessage()); log.error(e, e.getMessage());
if (e instanceof InterruptedException) { if (e instanceof InterruptedException) {
Thread.currentThread().interrupt(); Thread.currentThread().interrupt();
break;
} else if (e instanceof SocketException) { } else if (e instanceof SocketException) {
// This is antagonistic to general Closeable contract in Java,
// it is needed to allow re-connection in case of the socket is closed due long period of inactivity
pickledGraphite.close();
log.warn("Trying to re-connect to graphite server");
pickledGraphite.connect(); pickledGraphite.connect();
} }
} }
} }
pickledGraphite.flush();
} }
catch (Exception e) { catch (Exception e) {
log.error(e, e.getMessage()); log.error(e, e.getMessage());