Apache
/
druid
mirror of https://github.com/apache/druid.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

DirectDruidClient: Fix division by zero. (#4206) 

* DirectDruidClient: Fix division by zero.

Introduced in #3954 when some floating math was changed to
integer math. This patch restores the old math.

* Added comment.
This commit is contained in:
Gian Merlino 2017-04-25 13:03:00 +09:00 committed by GitHub
parent de815da942
commit 809112cd5f
1 changed files with 3 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
server/src/main/java/io/druid/client/DirectDruidClient.java
View File

@ -269,13 +269,14 @@ public class DirectDruidClient<T> implements QueryRunner<T>
{ {
long stopTimeNs = System.nanoTime(); long stopTimeNs = System.nanoTime();
long nodeTimeNs = stopTimeNs - responseStartTimeNs; long nodeTimeNs = stopTimeNs - responseStartTimeNs;
final long nodeTimeMs = TimeUnit.NANOSECONDS.toMillis(nodeTimeNs);
log.debug( log.debug(
"Completed queryId[%s] request to url[%s] with %,d bytes returned in %,d millis [%,f b/s].", "Completed queryId[%s] request to url[%s] with %,d bytes returned in %,d millis [%,f b/s].",
query.getId(), query.getId(),
url, url,
byteCount.get(), byteCount.get(),
TimeUnit.NANOSECONDS.toMillis(nodeTimeNs), nodeTimeMs,
byteCount.get() / TimeUnit.NANOSECONDS.toSeconds(nodeTimeNs) byteCount.get() / (0.001 * nodeTimeMs) // Floating math; division by zero will yield Inf, not exception
); );
queryMetrics.reportNodeTime(nodeTimeNs); queryMetrics.reportNodeTime(nodeTimeNs);
queryMetrics.reportNodeBytes(byteCount.get()); queryMetrics.reportNodeBytes(byteCount.get());