From 81bc2890dc96e28736c601db06dd1d084106e618 Mon Sep 17 00:00:00 2001
From: xvrl <xavier@metamarkets.com>
Date: Mon, 10 Dec 2012 17:10:20 -0800
Subject: [PATCH] configuration option to switch cache implementations

---
 .../druid/client/cache/CacheConfig.java       | 11 +++++
 .../com/metamx/druid/http/BrokerNode.java     | 40 +++++++++++++++----
 2 files changed, 43 insertions(+), 8 deletions(-)
 create mode 100644 client/src/main/java/com/metamx/druid/client/cache/CacheConfig.java

diff --git a/client/src/main/java/com/metamx/druid/client/cache/CacheConfig.java b/client/src/main/java/com/metamx/druid/client/cache/CacheConfig.java
new file mode 100644
index 00000000000..e970363e0e5
--- /dev/null
+++ b/client/src/main/java/com/metamx/druid/client/cache/CacheConfig.java
@@ -0,0 +1,11 @@
+package com.metamx.druid.client.cache;
+
+import org.skife.config.Config;
+import org.skife.config.Default;
+
+public abstract class CacheConfig
+{
+  @Config("druid.bard.cache.type")
+  @Default("local")
+  public abstract String getType();
+}
diff --git a/client/src/main/java/com/metamx/druid/http/BrokerNode.java b/client/src/main/java/com/metamx/druid/http/BrokerNode.java
index 0bcab531f4d..aa14b440104 100644
--- a/client/src/main/java/com/metamx/druid/http/BrokerNode.java
+++ b/client/src/main/java/com/metamx/druid/http/BrokerNode.java
@@ -35,9 +35,12 @@ import com.metamx.druid.client.CachingClusteredClient;
 import com.metamx.druid.client.ClientConfig;
 import com.metamx.druid.client.ClientInventoryManager;
 import com.metamx.druid.client.cache.CacheBroker;
+import com.metamx.druid.client.cache.CacheConfig;
 import com.metamx.druid.client.cache.CacheMonitor;
 import com.metamx.druid.client.cache.MapCacheBroker;
 import com.metamx.druid.client.cache.MapCacheBrokerConfig;
+import com.metamx.druid.client.cache.MemcachedCacheBroker;
+import com.metamx.druid.client.cache.MemcachedCacheBrokerConfig;
 import com.metamx.druid.initialization.Initialization;
 import com.metamx.druid.initialization.ServiceDiscoveryConfig;
 import com.metamx.druid.jackson.DefaultObjectMapper;
@@ -66,6 +69,10 @@ public class BrokerNode extends QueryableNode<BrokerNode>
 {
   private static final Logger log = new Logger(BrokerNode.class);
 
+  public static final String CACHE_TYPE_LOCAL = "local";
+  public static final String CACHE_TYPE_MEMCACHED = "memcached";
+  public static final String CACHE_PROPERTY_PREFIX = "druid.bard.cache";
+
   private final List<Module> extraModules = Lists.newArrayList();
   private final List<String> pathsForGuiceFilter = Lists.newArrayList();
 
@@ -233,14 +240,31 @@ public class BrokerNode extends QueryableNode<BrokerNode>
   private void initializeCacheBroker()
   {
     if (cacheBroker == null) {
-      setCacheBroker(
-          MapCacheBroker.create(
-              getConfigFactory().buildWithReplacements(
-                  MapCacheBrokerConfig.class,
-                  ImmutableMap.of("prefix", "druid.bard.cache")
-              )
-          )
-      );
+      String cacheType = getConfigFactory()
+          .build(CacheConfig.class)
+          .getType();
+
+      if (cacheType.equals(CACHE_TYPE_LOCAL)) {
+        setCacheBroker(
+            MapCacheBroker.create(
+                getConfigFactory().buildWithReplacements(
+                    MapCacheBrokerConfig.class,
+                    ImmutableMap.of("prefix", CACHE_PROPERTY_PREFIX)
+                )
+            )
+        );
+      } else if (cacheType.equals(CACHE_TYPE_MEMCACHED)) {
+        setCacheBroker(
+            MemcachedCacheBroker.create(
+                getConfigFactory().buildWithReplacements(
+                    MemcachedCacheBrokerConfig.class,
+                    ImmutableMap.of("prefix", CACHE_PROPERTY_PREFIX)
+                )
+            )
+        );
+      } else {
+        throw new ISE("Unknown cache type [%s]", cacheType);
+      }
     }
   }