Apache
/
druid
mirror of https://github.com/apache/druid.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Make lookups more idempotent on update requests. (#2954) 

* No longer fails if an update fails but it shouldn't have replaced it
This commit is contained in:
Charles Allen 2016-05-11 11:22:35 -07:00 committed by Xavier Léauté
parent f2510cf125
commit 81cab8a7bb
1 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
server/src/main/java/io/druid/query/lookup/LookupModule.java
View File

@ -118,7 +118,8 @@ class LookupListeningResource extends ListenerResource
for (final String name : lookups.keySet()) { for (final String name : lookups.keySet()) {
final LookupExtractorFactory factory = lookups.get(name); final LookupExtractorFactory factory = lookups.get(name);
try { try {
if (!manager.updateIfNew(name, factory)) { // Only fail if it should have updated but didn't.
if (!manager.updateIfNew(name, factory) && factory.replaces(manager.get(name))) {
failedUpdates.put(name, factory); failedUpdates.put(name, factory);
} }
} }