Apache
/
druid
mirror of https://github.com/apache/druid.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Fix SQL Server select query in createInactiveStatusesSinceQuery() method. (#5901) 

* Fix SQL Server select query in createInactiveStatusesSinceQuery() method.

SQL server does not support LIMIT N in select queries. Instead it has TOP N to limiting number of query results.
And TOP N is already added in the select statement as per maxNumStatuses value.

* Add parentheses for TOP in SELECT statement as SQL Servers no longer support TOP without parentheses.
This commit is contained in:
mhshimul 2018-07-03 23:46:47 +06:00 committed by Nishant Bangarwa
parent b6c957b0d2
commit 867f6a9e2b
1 changed files with 2 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
server/src/main/java/io/druid/metadata/SQLServerMetadataStorageActionHandler.java
View File

@ -49,7 +49,7 @@ public class SQLServerMetadataStorageActionHandler<EntryType, StatusType, LogTyp
Handle handle, DateTime timestamp, @Nullable Integer maxNumStatuses, @Nullable String datasource Handle handle, DateTime timestamp, @Nullable Integer maxNumStatuses, @Nullable String datasource
) )
{ {
String sql = maxNumStatuses == null ? "SELECT " : "SELECT TOP :n "; String sql = maxNumStatuses == null ? "SELECT " : "SELECT TOP (:n) ";
sql += StringUtils.format( sql += StringUtils.format(
" id, " " id, "
@ -64,9 +64,7 @@ public class SQLServerMetadataStorageActionHandler<EntryType, StatusType, LogTyp
+ "ORDER BY created_date DESC", + "ORDER BY created_date DESC",
getEntryTable() getEntryTable()
); );
if (maxNumStatuses != null) {
sql += " LIMIT :n";
}
Query<Map<String, Object>> query = handle.createQuery(sql).bind("start", timestamp.toString()); Query<Map<String, Object>> query = handle.createQuery(sql).bind("start", timestamp.toString());
if (maxNumStatuses != null) { if (maxNumStatuses != null) {