From 885b975c9574e3cfc4aae1cfccfd749b4dbb6e35 Mon Sep 17 00:00:00 2001 From: Clint Wylie Date: Tue, 20 Mar 2018 16:04:08 -0700 Subject: [PATCH] fix LongsColumnWithNulls and FloatsColumnWithNulls to override isNull in order to actually use nullValueBitmap (#5510) --- .../java/io/druid/segment/column/FloatsColumnWithNulls.java | 6 ++++++ .../java/io/druid/segment/column/LongsColumnWithNulls.java | 6 ++++++ 2 files changed, 12 insertions(+) diff --git a/processing/src/main/java/io/druid/segment/column/FloatsColumnWithNulls.java b/processing/src/main/java/io/druid/segment/column/FloatsColumnWithNulls.java index 016c911527f..1d8e498ce3e 100644 --- a/processing/src/main/java/io/druid/segment/column/FloatsColumnWithNulls.java +++ b/processing/src/main/java/io/druid/segment/column/FloatsColumnWithNulls.java @@ -44,6 +44,12 @@ class FloatsColumnWithNulls extends FloatsColumn return column.makeColumnValueSelector(offset, nullValueBitmap); } + @Override + public boolean isNull(int rowNum) + { + return nullValueBitmap.get(rowNum); + } + @Override public void inspectRuntimeShape(RuntimeShapeInspector inspector) { diff --git a/processing/src/main/java/io/druid/segment/column/LongsColumnWithNulls.java b/processing/src/main/java/io/druid/segment/column/LongsColumnWithNulls.java index 6aad278b016..cd6689df712 100644 --- a/processing/src/main/java/io/druid/segment/column/LongsColumnWithNulls.java +++ b/processing/src/main/java/io/druid/segment/column/LongsColumnWithNulls.java @@ -44,6 +44,12 @@ class LongsColumnWithNulls extends LongsColumn return column.makeColumnValueSelector(offset, nullValueBitmap); } + @Override + public boolean isNull(int rowNum) + { + return nullValueBitmap.get(rowNum); + } + @Override public void inspectRuntimeShape(RuntimeShapeInspector inspector) {