From 8b570ab1301f8dd4ebd7839d7bd5bc47b0a92188 Mon Sep 17 00:00:00 2001 From: Slim Date: Thu, 5 May 2016 12:38:40 -0500 Subject: [PATCH] make it clear what LookupExtractorFactory start/stop methods return (#2925) --- .../io/druid/query/lookup/LookupExtractorFactory.java | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/processing/src/main/java/io/druid/query/lookup/LookupExtractorFactory.java b/processing/src/main/java/io/druid/query/lookup/LookupExtractorFactory.java index a18fed85db5..bec1e07feb0 100644 --- a/processing/src/main/java/io/druid/query/lookup/LookupExtractorFactory.java +++ b/processing/src/main/java/io/druid/query/lookup/LookupExtractorFactory.java @@ -35,19 +35,19 @@ public interface LookupExtractorFactory extends Supplier /** *

* This method will be called to start the LookupExtractor upon registered - * Calling start multiple times should not lead to any failure and suppose to return true in both cases. + * Calling start multiple times should return true if successfully started. *

* - * @return true if start successfully started the {@link LookupExtractor} + * @return Returns false if is not successfully started the {@link LookupExtractor} otherwise returns true. */ public boolean start(); /** *

* This method will be called to stop the LookupExtractor upon deletion. - * Calling this method multiple times should not lead to any failure. + * Calling this method multiple times should always return true if successfully closed. *

- * @return true if successfully closed the {@link LookupExtractor} + * @return Returns false if not successfully closed the {@link LookupExtractor} otherwise returns true */ public boolean close(); /**