Apache
/
druid
mirror of https://github.com/apache/druid.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

1) Better error message when aggregators want more memory than is available.

This commit is contained in:
Eric Tschetter 2013-01-14 18:00:51 -06:00
parent 135474e49e
commit 998f0bf3c8
1 changed files with 14 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
server/src/main/java/com/metamx/druid/query/group/GroupByQueryEngine.java
View File

@ -236,6 +236,11 @@ public class GroupByQueryEngine
}
}
public int getIncrement()
{
return increment;
}
public int[] getIncrements()
{
return increments;
@ -301,11 +306,11 @@ public class GroupByQueryEngine
return delegate.next();
}
if (cursor.isDone()) {
if (unprocessedKeys == null && cursor.isDone()) {
throw new NoSuchElementException();
}
final PositionMaintainer positionMaintainer = new PositionMaintainer(0, sizesRequired, metricsBuffer.limit());
final PositionMaintainer positionMaintainer = new PositionMaintainer(0, sizesRequired, metricsBuffer.remaining());
final RowUpdater rowUpdater = new RowUpdater(metricsBuffer, aggregators, positionMaintainer);
if (unprocessedKeys != null) {
for (ByteBuffer key : unprocessedKeys) {
@ -327,6 +332,13 @@ public class GroupByQueryEngine
cursor.advance();
}
if (rowUpdater.getPositions().isEmpty() && unprocessedKeys != null) {
throw new ISE(
"Not enough memory to process even a single item. Required [%,d] memory, but only have[%,d]",
positionMaintainer.getIncrement(), metricsBuffer.remaining()
);
}
delegate = FunctionalIterator
.create(rowUpdater.getPositions().entrySet().iterator())
.transform(