Fix maxRowsInMemory default for streaming (#17028)

* fix maxRowsInMemory

* fix button css
This commit is contained in:
Vadim Ogievetsky 2024-09-11 08:43:00 -07:00 committed by GitHub
parent 5de84253d8
commit 9e1544e9c4
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
3 changed files with 10 additions and 3 deletions

View File

@ -57,7 +57,7 @@ export interface Field<M> {
| 'json'
| 'interval'
| 'custom';
defaultValue?: any;
defaultValue?: Functor<M, any>;
emptyValue?: any;
suggestions?: Functor<M, Suggestion[]>;
placeholder?: Functor<M, string>;
@ -131,7 +131,9 @@ export class AutoForm<T extends Record<string, any>> extends React.PureComponent
const required = AutoForm.evaluateFunctor(field.required, model, false);
return {
required,
defaultValue: required ? undefined : field.defaultValue,
defaultValue: required
? undefined
: AutoForm.evaluateFunctor(field.defaultValue, model as any, undefined),
modelValue: deepGet(model as any, field.name),
};
}

View File

@ -2045,7 +2045,7 @@ const TUNING_FORM_FIELDS: Field<IngestionSpec>[] = [
{
name: 'spec.tuningConfig.maxRowsInMemory',
type: 'number',
defaultValue: 1000000,
defaultValue: (spec: IngestionSpec) => (isStreamingSpec(spec) ? 150000 : 1000000),
info: <>Used in determining when intermediate persists to disk should occur.</>,
},
{

View File

@ -64,6 +64,11 @@ body {
}
}
// Make segmented control buttons appear blue when they are primary
.#{$bp-ns}-segmented-control > .#{$bp-ns}-button.#{$bp-ns}-small.#{$bp-ns}-intent-primary {
color: $blue5;
}
// Prevent popover menus from being longer than 45% of available height, let them scroll instead
.#{$bp-ns}-popover-content > .#{$bp-ns}-menu {
max-height: 47vh;