Apache/druid
1
0
Fork 0
mirror of https://github.com/apache/druid.git synced 2025-02-10 03:55:02 +00:00
Code Issues Packages Projects Releases Wiki Activity

Detailed error message when unable to create temp dir (#5648)

Browse Source
This commit is contained in:
Kirill Kozlov 2018-04-18 00:12:46 +02:00 committed by Jihoon Son
parent 8e441cd142
commit a7ba2bf275
2 changed files with 29 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
server/src/main/java/io/druid/segment/indexing/RealtimeTuningConfig.java
View File

@ -23,6 +23,7 @@ import com.fasterxml.jackson.annotation.JsonCreator;
import com.fasterxml.jackson.annotation.JsonProperty; import com.fasterxml.jackson.annotation.JsonProperty;
import com.google.common.base.Preconditions; import com.google.common.base.Preconditions;
import com.google.common.io.Files; import com.google.common.io.Files;
import io.druid.java.util.common.ISE;
import io.druid.segment.IndexSpec; import io.druid.segment.IndexSpec;
import io.druid.segment.realtime.appenderator.AppenderatorConfig; import io.druid.segment.realtime.appenderator.AppenderatorConfig;
import io.druid.segment.realtime.plumber.IntervalStartVersioningPolicy; import io.druid.segment.realtime.plumber.IntervalStartVersioningPolicy;
@ -55,8 +56,16 @@ public class RealtimeTuningConfig implements TuningConfig, AppenderatorConfig
private static File createNewBasePersistDirectory() private static File createNewBasePersistDirectory()
{ {
try {
return Files.createTempDir(); return Files.createTempDir();
} }
catch (IllegalStateException e) {
String messageTemplate = "Failed to create temporary directory in [%s]! " +
"Make sure the `java.io.tmpdir` property is set to an existing and writable directory " +
"with enough free space.";
throw new ISE(e, messageTemplate, System.getProperty("java.io.tmpdir"));
}
}
// Might make sense for this to be a builder // Might make sense for this to be a builder
public static RealtimeTuningConfig makeDefaultTuningConfig(final @Nullable File basePersistDirectory) public static RealtimeTuningConfig makeDefaultTuningConfig(final @Nullable File basePersistDirectory)

19
server/src/test/java/io/druid/segment/indexing/RealtimeTuningConfigTest.java
View File

@ -28,6 +28,7 @@ import org.junit.Assert;
import org.junit.Test; import org.junit.Test;
import java.io.File; import java.io.File;
import java.util.UUID;
public class RealtimeTuningConfigTest public class RealtimeTuningConfigTest
{ {
@ -39,6 +40,24 @@ public class RealtimeTuningConfigTest
Assert.assertNotEquals(tuningConfig1.getBasePersistDirectory(), tuningConfig2.getBasePersistDirectory()); Assert.assertNotEquals(tuningConfig1.getBasePersistDirectory(), tuningConfig2.getBasePersistDirectory());
} }
@Test
public void testErrorMessageIsMeaningfulWhenUnableToCreateTemporaryDirectory()
{
String propertyName = "java.io.tmpdir";
String originalValue = System.getProperty(propertyName);
try {
String nonExistedDirectory = "/tmp/" + UUID.randomUUID();
System.setProperty(propertyName, nonExistedDirectory);
RealtimeTuningConfig.makeDefaultTuningConfig(null);
}
catch (IllegalStateException e) {
Assert.assertTrue(e.getMessage().startsWith("Failed to create temporary directory in"));
}
finally {
System.setProperty(propertyName, originalValue);
}
}
@Test @Test
public void testSpecificBasePersistDirectory() public void testSpecificBasePersistDirectory()
{ {