Apache
/
druid
mirror of https://github.com/apache/druid.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

clarify error messaging for parallel indexing task when when missing numShards or intervals (#8513)

This commit is contained in:
Clint Wylie 2019-09-11 20:47:27 -07:00 committed by Fangjin Yang
parent 1498250204
commit b00dd84fa2
2 changed files with 10 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
indexing-service/src/main/java/org/apache/druid/indexing/common/task/batch/parallel/ParallelIndexSupervisorTask.java
View File

@ -183,13 +183,14 @@ public class ParallelIndexSupervisorTask extends AbstractBatchIndexTask implemen
throw new IAE("[%s] should implement FiniteFirehoseFactory", firehoseFactory.getClass().getSimpleName());
}
if (ingestionSchema.getTuningConfig().isForceGuaranteedRollup()
&& (ingestionSchema.getTuningConfig().getNumShards() == null
|| ingestionSchema.getDataSchema().getGranularitySpec().inputIntervals().isEmpty())) {
throw new ISE(
"forceGuaranteedRollup is set "
+ "but numShards is missing in partitionsSpec or intervals is missing in granularitySpec"
);
if (ingestionSchema.getTuningConfig().isForceGuaranteedRollup()) {
if (ingestionSchema.getTuningConfig().getNumShards() == null) {
throw new ISE("forceGuaranteedRollup is set but numShards is missing in partitionsSpec");
}
if (ingestionSchema.getDataSchema().getGranularitySpec().inputIntervals().isEmpty()) {
throw new ISE("forceGuaranteedRollup is set but intervals is missing in granularitySpec");
}
}
this.baseFirehoseFactory = (FiniteFirehoseFactory) firehoseFactory;

6
indexing-service/src/test/java/org/apache/druid/indexing/common/task/batch/parallel/MultiPhaseParallelIndexingTest.java
View File

@ -159,8 +159,7 @@ public class MultiPhaseParallelIndexingTest extends AbstractParallelIndexSupervi
{
expectedException.expect(IllegalStateException.class);
expectedException.expectMessage(
"forceGuaranteedRollup is set but numShards is missing in partitionsSpec "
+ "or intervals is missing in granularitySpec"
"forceGuaranteedRollup is set but intervals is missing in granularitySpec"
);
newTask(
null,
@ -177,8 +176,7 @@ public class MultiPhaseParallelIndexingTest extends AbstractParallelIndexSupervi
{
expectedException.expect(IllegalStateException.class);
expectedException.expectMessage(
"forceGuaranteedRollup is set but numShards is missing in partitionsSpec "
+ "or intervals is missing in granularitySpec"
"forceGuaranteedRollup is set but numShards is missing in partitionsSpec"
);
newTask(
Intervals.of("2017/2018"),