Apache/druid
1
0
Fork 0
mirror of https://github.com/apache/druid.git synced 2025-02-20 00:47:40 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix performance regression from #2753 in IndexMerger (#2841)

Browse Source
This commit is contained in:
Jonathan Wei 2016-04-14 21:39:41 -07:00 committed by Fangjin Yang
parent a26134575b
commit b534f7203c
1 changed files with 4 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
processing/src/main/java/io/druid/segment/IndexMerger.java
View File

@ -946,9 +946,6 @@ public class IndexMerger
} }
MutableBitmap bitset = bitmapSerdeFactory.getBitmapFactory().makeEmptyMutableBitmap(); MutableBitmap bitset = bitmapSerdeFactory.getBitmapFactory().makeEmptyMutableBitmap();
if ((dictId == 0) && (Iterables.getFirst(dimVals, "") == null)) {
bitset.or(nullRowsList.get(i));
}
for (Integer row : CombiningIterable.createSplatted( for (Integer row : CombiningIterable.createSplatted(
convertedInverteds, convertedInverteds,
Ordering.<Integer>natural().nullsFirst() Ordering.<Integer>natural().nullsFirst()
@ -958,6 +955,10 @@ public class IndexMerger
} }
} }
if ((dictId == 0) && (Iterables.getFirst(dimVals, "") == null)) {
bitset.or(nullRowsList.get(i));
}
writer.write( writer.write(
bitmapSerdeFactory.getBitmapFactory().makeImmutableBitmap(bitset) bitmapSerdeFactory.getBitmapFactory().makeImmutableBitmap(bitset)
); );