From b654096194240cbc576732c4fda8349564b28c7c Mon Sep 17 00:00:00 2001 From: Jihoon Son Date: Fri, 16 Aug 2019 14:47:37 -0700 Subject: [PATCH] Fix equals for ArrayOfDoublesSketchAggregatorFactory (#8326) --- ...ArrayOfDoublesSketchAggregatorFactory.java | 2 +- ...yOfDoublesSketchAggregatorFactoryTest.java | 21 +++++++++++++++++++ 2 files changed, 22 insertions(+), 1 deletion(-) diff --git a/extensions-core/datasketches/src/main/java/org/apache/druid/query/aggregation/datasketches/tuple/ArrayOfDoublesSketchAggregatorFactory.java b/extensions-core/datasketches/src/main/java/org/apache/druid/query/aggregation/datasketches/tuple/ArrayOfDoublesSketchAggregatorFactory.java index 87590832f4c..001ed0b0fe4 100644 --- a/extensions-core/datasketches/src/main/java/org/apache/druid/query/aggregation/datasketches/tuple/ArrayOfDoublesSketchAggregatorFactory.java +++ b/extensions-core/datasketches/src/main/java/org/apache/druid/query/aggregation/datasketches/tuple/ArrayOfDoublesSketchAggregatorFactory.java @@ -323,7 +323,7 @@ public class ArrayOfDoublesSketchAggregatorFactory extends AggregatorFactory if (!Objects.equals(metricColumns, that.metricColumns)) { return false; } - return numberOfValues != that.numberOfValues; + return numberOfValues == that.numberOfValues; } @Override diff --git a/extensions-core/datasketches/src/test/java/org/apache/druid/query/aggregation/datasketches/tuple/ArrayOfDoublesSketchAggregatorFactoryTest.java b/extensions-core/datasketches/src/test/java/org/apache/druid/query/aggregation/datasketches/tuple/ArrayOfDoublesSketchAggregatorFactoryTest.java index 59571438be0..d99cbd0ac59 100644 --- a/extensions-core/datasketches/src/test/java/org/apache/druid/query/aggregation/datasketches/tuple/ArrayOfDoublesSketchAggregatorFactoryTest.java +++ b/extensions-core/datasketches/src/test/java/org/apache/druid/query/aggregation/datasketches/tuple/ArrayOfDoublesSketchAggregatorFactoryTest.java @@ -19,6 +19,7 @@ package org.apache.druid.query.aggregation.datasketches.tuple; +import com.google.common.collect.ImmutableList; import com.yahoo.sketches.tuple.ArrayOfDoublesSketch; import com.yahoo.sketches.tuple.ArrayOfDoublesUpdatableSketch; import com.yahoo.sketches.tuple.ArrayOfDoublesUpdatableSketchBuilder; @@ -55,4 +56,24 @@ public class ArrayOfDoublesSketchAggregatorFactoryTest Assert.assertEquals(3, combiner.getObject().getEstimate(), 0); } + @Test + public void testEquals() + { + final ArrayOfDoublesSketchAggregatorFactory a1 = new ArrayOfDoublesSketchAggregatorFactory( + "name", + "field", + 1, + ImmutableList.of("met"), + 1 + ); + final ArrayOfDoublesSketchAggregatorFactory a2 = new ArrayOfDoublesSketchAggregatorFactory( + "name", + "field", + 1, + ImmutableList.of("met"), + 1 + ); + + Assert.assertEquals(a1, a2); + } }