From b6a16b5eb61632ad935e8982eea12e245e43b195 Mon Sep 17 00:00:00 2001 From: Himanshu Date: Tue, 24 Sep 2019 07:12:09 -0700 Subject: [PATCH] make it possible to not emit cache metrics and disable by default (#8561) --- services/src/main/java/org/apache/druid/cli/CliBroker.java | 4 ---- .../src/main/java/org/apache/druid/cli/CliHistorical.java | 3 --- 2 files changed, 7 deletions(-) diff --git a/services/src/main/java/org/apache/druid/cli/CliBroker.java b/services/src/main/java/org/apache/druid/cli/CliBroker.java index 6936375c359..cf1ea3ca1bf 100644 --- a/services/src/main/java/org/apache/druid/cli/CliBroker.java +++ b/services/src/main/java/org/apache/druid/cli/CliBroker.java @@ -29,7 +29,6 @@ import org.apache.druid.client.CachingClusteredClient; import org.apache.druid.client.HttpServerInventoryViewResource; import org.apache.druid.client.TimelineServerView; import org.apache.druid.client.cache.CacheConfig; -import org.apache.druid.client.cache.CacheMonitor; import org.apache.druid.client.selector.CustomTierSelectorStrategyConfig; import org.apache.druid.client.selector.ServerSelectorStrategy; import org.apache.druid.client.selector.TierSelectorStrategy; @@ -52,7 +51,6 @@ import org.apache.druid.server.ClientInfoResource; import org.apache.druid.server.ClientQuerySegmentWalker; import org.apache.druid.server.http.BrokerResource; import org.apache.druid.server.initialization.jetty.JettyServerInitializer; -import org.apache.druid.server.metrics.MetricsModule; import org.apache.druid.server.metrics.QueryCountStatsProvider; import org.apache.druid.server.router.TieredBrokerConfig; import org.apache.druid.sql.guice.SqlModule; @@ -118,8 +116,6 @@ public class CliBroker extends ServerRunnable Jerseys.addResource(binder, HttpServerInventoryViewResource.class); - MetricsModule.register(binder, CacheMonitor.class); - LifecycleModule.register(binder, Server.class); diff --git a/services/src/main/java/org/apache/druid/cli/CliHistorical.java b/services/src/main/java/org/apache/druid/cli/CliHistorical.java index 16deaf061ca..cf81439d53f 100644 --- a/services/src/main/java/org/apache/druid/cli/CliHistorical.java +++ b/services/src/main/java/org/apache/druid/cli/CliHistorical.java @@ -24,7 +24,6 @@ import com.google.inject.Module; import com.google.inject.name.Names; import io.airlift.airline.Command; import org.apache.druid.client.cache.CacheConfig; -import org.apache.druid.client.cache.CacheMonitor; import org.apache.druid.discovery.DataNodeService; import org.apache.druid.discovery.LookupNodeService; import org.apache.druid.discovery.NodeType; @@ -49,7 +48,6 @@ import org.apache.druid.server.coordination.ZkCoordinator; import org.apache.druid.server.http.HistoricalResource; import org.apache.druid.server.http.SegmentListerResource; import org.apache.druid.server.initialization.jetty.JettyServerInitializer; -import org.apache.druid.server.metrics.MetricsModule; import org.apache.druid.server.metrics.QueryCountStatsProvider; import org.eclipse.jetty.server.Server; @@ -100,7 +98,6 @@ public class CliHistorical extends ServerRunnable JsonConfigProvider.bind(binder, "druid.historical.cache", CacheConfig.class); binder.install(new CacheModule()); - MetricsModule.register(binder, CacheMonitor.class); bindAnnouncer( binder,