Apache
/
druid
mirror of https://github.com/apache/druid.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Disable function code coverage check (#9933) 

As observed in https://github.com/apache/druid/pull/9905 and
https://github.com/apache/druid/pull/9915, the function code coverage
check flags false positive issues, so it should be disabled for now.
This commit is contained in:
Chi Cao Minh 2020-05-26 20:13:08 -07:00 committed by GitHub
parent 6130a834c2
commit b8c2266aa0
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 3 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
.travis.yml
View File

@ -166,7 +166,8 @@ jobs:
project_files="$(echo "${all_files}" | grep "${regex}" || [[ $? == 1 ]])"; project_files="$(echo "${all_files}" | grep "${regex}" || [[ $? == 1 ]])";
fi fi
- for f in ${project_files}; do echo $f; done # for debugging - for f in ${project_files}; do echo $f; done # for debugging
# Check diff code coverage for the maven projects being tested (retry install in case of network error) # Check diff code coverage for the maven projects being tested (retry install in case of network error).
# Currently, the function coverage check is not reliable, so it is disabled.
- > - >
if [ -n "${project_files}" ]; then if [ -n "${project_files}" ]; then
travis_retry npm install @connectis/diff-test-coverage@1.5.3 travis_retry npm install @connectis/diff-test-coverage@1.5.3
@ -176,7 +177,7 @@ jobs:
--type jacoco --type jacoco
--line-coverage 65 --line-coverage 65
--branch-coverage 65 --branch-coverage 65
--function-coverage 80 --function-coverage 0
-- --
|| { printf "\nDiff code coverage check failed. To view coverage report, run 'mvn clean test jacoco:report' and open 'target/site/jacoco/index.html'\n" && false; } || { printf "\nDiff code coverage check failed. To view coverage report, run 'mvn clean test jacoco:report' and open 'target/site/jacoco/index.html'\n" && false; }
fi fi