Apache
/
druid
mirror of https://github.com/apache/druid.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Rename BitmapOperationTest base class to avoid flaky test. (#11102) 

PR #10936 renamed BitmapBenchmark, the parent of a couple of bitmap tests, to
BitmapOperationTest. This patch renames it to BitmapOperationTestBase so JUnit
doesn't pick it up as a test case. When JUnit picks it up, it becomes a flaky
test, since its behavior and correctness depends on whether it runs before
or after its subclasses.
This commit is contained in:
Gian Merlino 2021-04-13 08:01:15 -07:00 committed by GitHub
parent c8e394015d
commit c158207ab6
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
processing/src/test/java/org/apache/druid/collections/bitmap/BitmapOperationAgainstConsecutiveRunsTest.java
View File

@ -26,7 +26,7 @@ import org.roaringbitmap.buffer.MutableRoaringBitmap;
import java.util.BitSet;
public class BitmapOperationAgainstConsecutiveRunsTest extends BitmapOperationTest
public class BitmapOperationAgainstConsecutiveRunsTest extends BitmapOperationTestBase
{
public static final double DENSITY = 0.001;

2
processing/src/test/java/org/apache/druid/collections/bitmap/BitmapOperationAgainstUniformDistributionTest.java
View File

@ -26,7 +26,7 @@ import org.roaringbitmap.buffer.MutableRoaringBitmap;
import java.util.BitSet;
public class BitmapOperationAgainstUniformDistributionTest extends BitmapOperationTest
public class BitmapOperationAgainstUniformDistributionTest extends BitmapOperationTestBase
{
public static final double DENSITY = 0.01;
public static final int MIN_INTERSECT = 50;

2
processing/src/test/java/org/apache/druid/collections/bitmap/BitmapOperationTest.java → processing/src/test/java/org/apache/druid/collections/bitmap/BitmapOperationTestBase.java
View File

@ -35,7 +35,7 @@ import java.util.Arrays;
import java.util.Locale;
import java.util.Random;
public class BitmapOperationTest
public abstract class BitmapOperationTestBase
{
public static final int BITMAP_LENGTH = 500_000;
public static final int NUM_BITMAPS = 1000;