RealtimeIndexTask: Reword comments

This commit is contained in:
Gian Merlino 2013-03-14 12:49:17 -07:00
parent 9fe6a37f86
commit c34108418a
1 changed files with 10 additions and 7 deletions

View File

@ -158,11 +158,12 @@ public class RealtimeIndexTask extends AbstractTask
} }
}; };
// TODO -- This can block if there is lock contention, which will block plumber.getSink (and thus the firehose) // NOTE: getVersion will block if there is lock contention, which will block plumber.getSink
// TODO -- Shouldn't usually happen, since we don't expect people to submit tasks that intersect with the // NOTE: (and thus the firehose)
// TODO -- realtime window, but if they do it can be problematic.
// TODO -- If we decide to care, we can use more threads in the plumber such that waiting for the coordinator // Shouldn't usually happen, since we don't expect people to submit tasks that intersect with the
// TODO -- doesn't block data processing. // realtime window, but if they do it can be problematic. If we decide to care, we can use more threads in
// the plumber such that waiting for the coordinator doesn't block data processing.
final RealtimePlumberSchool.VersioningPolicy versioningPolicy = new RealtimePlumberSchool.VersioningPolicy() final RealtimePlumberSchool.VersioningPolicy versioningPolicy = new RealtimePlumberSchool.VersioningPolicy()
{ {
@Override @Override
@ -180,8 +181,10 @@ public class RealtimeIndexTask extends AbstractTask
} }
}; };
// TODO - Might need to have task id in segmentPusher path or some other way of making redundant realtime // NOTE: This pusher selects path based purely on global configuration and the DataSegment, which means
// TODO - workers not step on each other's toes when pushing segments to S3 // NOTE: that redundant realtime tasks will upload to the same location. This can cause index.zip and
// NOTE: descriptor.json to mismatch, or it can cause compute nodes to load different instances of the
// NOTE: "same" segment.
realtimePlumberSchool.setDataSegmentPusher(toolbox.getSegmentPusher()); realtimePlumberSchool.setDataSegmentPusher(toolbox.getSegmentPusher());
realtimePlumberSchool.setConglomerate(toolbox.getQueryRunnerFactoryConglomerate()); realtimePlumberSchool.setConglomerate(toolbox.getQueryRunnerFactoryConglomerate());
realtimePlumberSchool.setVersioningPolicy(versioningPolicy); realtimePlumberSchool.setVersioningPolicy(versioningPolicy);