Apache
/
druid
mirror of https://github.com/apache/druid.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Intern DataSegments in SQLMetadataSegmentManager (#3267) 

* Helps with heap pressure on coordinator
This commit is contained in:
Charles Allen 2016-07-21 16:46:08 -07:00 committed by Fangjin Yang
parent a42ccb6d19
commit c58bbfa0c6
1 changed files with 9 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
server/src/main/java/io/druid/metadata/SQLMetadataSegmentManager.java
View File

@ -25,6 +25,8 @@ import com.google.common.base.Supplier;
import com.google.common.base.Throwables; import com.google.common.base.Throwables;
import com.google.common.collect.Collections2; import com.google.common.collect.Collections2;
import com.google.common.collect.ImmutableMap; import com.google.common.collect.ImmutableMap;
import com.google.common.collect.Interner;
import com.google.common.collect.Interners;
import com.google.common.collect.Lists; import com.google.common.collect.Lists;
import com.google.common.collect.Ordering; import com.google.common.collect.Ordering;
import com.google.common.util.concurrent.ListenableFuture; import com.google.common.util.concurrent.ListenableFuture;
@ -59,7 +61,6 @@ import org.skife.jdbi.v2.tweak.ResultSetMapper;
import org.skife.jdbi.v2.util.ByteArrayMapper; import org.skife.jdbi.v2.util.ByteArrayMapper;
import java.io.IOException; import java.io.IOException;
import java.sql.Connection;
import java.sql.ResultSet; import java.sql.ResultSet;
import java.sql.SQLException; import java.sql.SQLException;
import java.util.ArrayList; import java.util.ArrayList;
@ -76,6 +77,7 @@ import java.util.concurrent.atomic.AtomicReference;
@ManageLifecycle @ManageLifecycle
public class SQLMetadataSegmentManager implements MetadataSegmentManager public class SQLMetadataSegmentManager implements MetadataSegmentManager
{ {
private static final Interner<DataSegment> DATA_SEGMENT_INTERNER = Interners.newWeakInterner();
private static final EmittingLogger log = new EmittingLogger(SQLMetadataSegmentManager.class); private static final EmittingLogger log = new EmittingLogger(SQLMetadataSegmentManager.class);
@ -194,10 +196,10 @@ public class SQLMetadataSegmentManager implements MetadataSegmentManager
) throws SQLException ) throws SQLException
{ {
try { try {
DataSegment segment = jsonMapper.readValue( final DataSegment segment = DATA_SEGMENT_INTERNER.intern(jsonMapper.readValue(
payload, payload,
DataSegment.class DataSegment.class
); ));
timeline.add( timeline.add(
segment.getInterval(), segment.getInterval(),
@ -464,7 +466,10 @@ public class SQLMetadataSegmentManager implements MetadataSegmentManager
throws SQLException throws SQLException
{ {
try { try {
return jsonMapper.readValue(r.getBytes("payload"), DataSegment.class); return DATA_SEGMENT_INTERNER.intern(jsonMapper.readValue(
r.getBytes("payload"),
DataSegment.class
));
} }
catch (IOException e) { catch (IOException e) {
log.makeAlert(e, "Failed to read segment from db."); log.makeAlert(e, "Failed to read segment from db.");