diff --git a/server/src/main/java/io/druid/client/cache/MemcachedCache.java b/server/src/main/java/io/druid/client/cache/MemcachedCache.java index 91357c58971..e0196b6db4a 100644 --- a/server/src/main/java/io/druid/client/cache/MemcachedCache.java +++ b/server/src/main/java/io/druid/client/cache/MemcachedCache.java @@ -74,6 +74,12 @@ public class MemcachedCache implements Cache { private static final Logger log = new Logger(MemcachedCache.class); + /** + * Default hash algorithm for cache distribution. + * + * If some other algorithms are considered as the default algorithm instead of this one, the cache distribution for + * those hash algorithms should be checked and compared using {@code CacheDistributionTest}. + */ final static HashAlgorithm MURMUR3_128 = new HashAlgorithm() { final HashFunction fn = Hashing.murmur3_128(); diff --git a/server/src/test/java/io/druid/client/cache/CacheDistributionTest.java b/server/src/test/java/io/druid/client/cache/CacheDistributionTest.java index 0c61e092d1f..bf8878fb739 100644 --- a/server/src/test/java/io/druid/client/cache/CacheDistributionTest.java +++ b/server/src/test/java/io/druid/client/cache/CacheDistributionTest.java @@ -32,6 +32,7 @@ import net.spy.memcached.util.DefaultKetamaNodeLocatorConfiguration; import org.apache.commons.codec.digest.DigestUtils; import org.easymock.EasyMock; import org.junit.BeforeClass; +import org.junit.Ignore; import org.junit.Test; import org.junit.runner.RunWith; import org.junit.runners.Parameterized; @@ -93,7 +94,10 @@ public class CacheDistributionTest this.reps = reps; } - // run to get a sense of cache key distribution for different ketama reps / hash functions + // Run to get a sense of cache key distribution for different ketama reps / hash functions + // This test is disabled by default because it's a qualitative test not an unit test and thus it have a meaning only + // when being run and checked by humans. + @Ignore @Test public void testDistribution() throws Exception {