Apache
/
druid
mirror of https://github.com/apache/druid.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

BenchmarkDataGenerator: Don't generate timestamps at the end instant of the interval. (#3242) 

Because timestamps at the end instant are not actually part of the interval. This
affected benchmark numbers, since it meant some data points would not be queried
(the interval for the query was based on getDataInterval) and also the
TimestampCheckingOffsets could not use the allWithinThreshold optimization.
This commit is contained in:
Gian Merlino 2016-07-13 21:50:10 -07:00 committed by Nishant
parent a931debf79
commit c622a25236
1 changed files with 5 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
benchmarks/src/main/java/io/druid/benchmark/datagen/BenchmarkDataGenerator.java
View File

@ -20,14 +20,12 @@
package io.druid.benchmark.datagen;
import com.google.common.base.Function;
import com.google.common.base.Predicate;
import com.google.common.collect.Iterables;
import com.google.common.base.Preconditions;
import com.google.common.collect.Lists;
import io.druid.data.input.InputRow;
import io.druid.data.input.MapBasedInputRow;
import org.joda.time.Interval;
import javax.annotation.Nullable;
import java.util.ArrayList;
import java.util.HashMap;
import java.util.List;
@ -79,7 +77,9 @@ public class BenchmarkDataGenerator
this.seed = seed;
this.startTime = interval.getStartMillis();
this.endTime = interval.getEndMillis();
this.endTime = interval.getEndMillis() - 1;
Preconditions.checkArgument(endTime >= startTime, "endTime >= startTime");
long timeDelta = endTime - startTime;
this.timestampIncrement = timeDelta / (numRows * 1.0);
@ -104,7 +104,7 @@ public class BenchmarkDataGenerator
this.currentTime = startTime;
dimensionNames = new ArrayList<>();
for (BenchmarkColumnSchema schema: columnSchemas) {
for (BenchmarkColumnSchema schema : columnSchemas) {
if (!schema.isMetric()) {
dimensionNames.add(schema.getName());
}