From c6f4f09557c1ddb0afedf68d96a2fb2baf039ffc Mon Sep 17 00:00:00 2001 From: Benedict Jin Date: Mon, 16 Sep 2019 17:07:47 +0800 Subject: [PATCH] Fix missing space in string literal and spurious Javadoc @param tags from LGTM (#8491) * Fix missing space in string literal * Fix spurious Javadoc @param tags --- .../src/main/java/org/apache/druid/guice/LifecycleModule.java | 4 ++-- .../apache/druid/indexing/kinesis/KinesisRecordSupplier.java | 2 +- .../org/apache/druid/query/scan/ScanQueryRunnerFactory.java | 2 +- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/core/src/main/java/org/apache/druid/guice/LifecycleModule.java b/core/src/main/java/org/apache/druid/guice/LifecycleModule.java index b2ec09bd48a..2de02d4fa73 100644 --- a/core/src/main/java/org/apache/druid/guice/LifecycleModule.java +++ b/core/src/main/java/org/apache/druid/guice/LifecycleModule.java @@ -57,7 +57,7 @@ public class LifecycleModule implements Module * it is not clear which is actually the best approach. This is more explicit, but eager bindings inside of modules * is less error-prone. * - * @param clazz, the class to instantiate + * @param clazz the class to instantiate * @return this, for chaining. */ public static void register(Binder binder, Class clazz) @@ -78,7 +78,7 @@ public class LifecycleModule implements Module * it is not clear which is actually the best approach. This is more explicit, but eager bindings inside of modules * is less error-prone. * - * @param clazz, the class to instantiate + * @param clazz the class to instantiate * @param annotation The annotation class to register with Guice * @return this, for chaining */ diff --git a/extensions-core/kinesis-indexing-service/src/main/java/org/apache/druid/indexing/kinesis/KinesisRecordSupplier.java b/extensions-core/kinesis-indexing-service/src/main/java/org/apache/druid/indexing/kinesis/KinesisRecordSupplier.java index 303d49061fe..b71f485fe26 100644 --- a/extensions-core/kinesis-indexing-service/src/main/java/org/apache/druid/indexing/kinesis/KinesisRecordSupplier.java +++ b/extensions-core/kinesis-indexing-service/src/main/java/org/apache/druid/indexing/kinesis/KinesisRecordSupplier.java @@ -319,7 +319,7 @@ public class KinesisRecordSupplier implements RecordSupplier catch (RejectedExecutionException e) { log.warn( e, - "Caught RejectedExecutionException, KinesisRecordSupplier for partition[%s] has likely temporarily shutdown the ExecutorService." + "Caught RejectedExecutionException, KinesisRecordSupplier for partition[%s] has likely temporarily shutdown the ExecutorService. " + "This is expected behavior after calling seek(), seekToEarliest() and seekToLatest()", streamPartition.getPartitionId() ); diff --git a/processing/src/main/java/org/apache/druid/query/scan/ScanQueryRunnerFactory.java b/processing/src/main/java/org/apache/druid/query/scan/ScanQueryRunnerFactory.java index 645f545ef28..8233315d5e8 100644 --- a/processing/src/main/java/org/apache/druid/query/scan/ScanQueryRunnerFactory.java +++ b/processing/src/main/java/org/apache/druid/query/scan/ScanQueryRunnerFactory.java @@ -295,7 +295,7 @@ public class ScanQueryRunnerFactory implements QueryRunnerFactory