From c8f91478106a2e78676dcc9ab4a3e2004cbb7af2 Mon Sep 17 00:00:00 2001 From: Zoltan Haindrich Date: Mon, 5 Aug 2024 14:23:54 +0000 Subject: [PATCH] minor fixes --- quidem-ut/README.md | 6 +++--- .../builtin/CountSqlAggregator.java | 1 - .../sql/calcite/util/CalciteTestBase.java | 18 ------------------ 3 files changed, 3 insertions(+), 22 deletions(-) diff --git a/quidem-ut/README.md b/quidem-ut/README.md index 5b594a3c8f4..7ff5feacee6 100644 --- a/quidem-ut/README.md +++ b/quidem-ut/README.md @@ -20,7 +20,7 @@ # Quidem UT Enables to write sql level tests easily. -Can be used to write tests against existing test backends (ComponentSupplier) - by doing so the testcases can be moved closer to the excercised codes. +Can be used to write tests against existing test backends (ComponentSupplier) - by doing so the testcases can be moved closer to the exercised codes. ## Usage @@ -39,8 +39,8 @@ sdk install maven # run mvn to see if it works mvn --version -# download druid sourcces (FIXME: change this to the main repo/branch before merging) -git clone --branch quidem-record https://github.com/kgyrtkirk/druid +# download druid sources +git clone https://github.com/apache/druid ``` diff --git a/sql/src/main/java/org/apache/druid/sql/calcite/aggregation/builtin/CountSqlAggregator.java b/sql/src/main/java/org/apache/druid/sql/calcite/aggregation/builtin/CountSqlAggregator.java index c28ac8eebb2..572d276a0bd 100644 --- a/sql/src/main/java/org/apache/druid/sql/calcite/aggregation/builtin/CountSqlAggregator.java +++ b/sql/src/main/java/org/apache/druid/sql/calcite/aggregation/builtin/CountSqlAggregator.java @@ -115,7 +115,6 @@ public class CountSqlAggregator implements SqlAggregator return null; } - // FIXME: is-all-literal if (args.isEmpty()) { // COUNT(*) return Aggregation.create(new CountAggregatorFactory(name)); diff --git a/sql/src/test/java/org/apache/druid/sql/calcite/util/CalciteTestBase.java b/sql/src/test/java/org/apache/druid/sql/calcite/util/CalciteTestBase.java index 9a69c62dc73..6b2e3efc718 100644 --- a/sql/src/test/java/org/apache/druid/sql/calcite/util/CalciteTestBase.java +++ b/sql/src/test/java/org/apache/druid/sql/calcite/util/CalciteTestBase.java @@ -93,24 +93,6 @@ public abstract class CalciteTestBase } } - // FIXME remove - public TempFolderOverTempDir temXMEXAXISporaryFolder = new TempFolderOverTempDir(); - - public class TempFolderOverTempDir - { - - public File newFolder() - { - return newTempFolder("unknown"); - } - - public File newFolder(String string) - { - return newTempFolder(string); - } - } - - /** * @deprecated prefer to make {@link DruidExpression} directly to ensure expression tests accurately test the full * expression structure, this method is just to have a convenient way to fix a very large number of existing tests