Apache/druid
1
0
Fork 0
mirror of https://github.com/apache/druid.git synced 2025-02-09 11:34:54 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix compilation failure due to missing constant MISSING_JOIN_CONVERSION (#16050)

Browse Source 
* Reintroduce variable MISSING_JOIN_CONVERSION

* Remove redundant constant MISSING_JOIN_CONVERSION2

* Correct fix to address failing tests
This commit is contained in:
Vishesh Garg 2024-03-06 13:04:39 +05:30 committed by GitHub
parent ddd9da2e09
commit cf9bc507f6
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
sql/src/test/java/org/apache/druid/sql/calcite/CalciteQueryTest.java
View File

@ -15307,7 +15307,6 @@ public class CalciteQueryTest extends BaseCalciteQueryTest
.run(); .run();
} }
@NotYetSupported(Modes.MISSING_JOIN_CONVERSION)
@Test @Test
public void testScanAndSortOnJoin() public void testScanAndSortOnJoin()
{ {
@ -15340,7 +15339,7 @@ public class CalciteQueryTest extends BaseCalciteQueryTest
.run(); .run();
} }
@NotYetSupported(Modes.MISSING_JOIN_CONVERSION) @NotYetSupported(Modes.WINDOW_OPERATOR_QUERY_ON_UNSUPPORTED_DATASOURCE)
@Test @Test
public void testWindowingOverJoin() public void testWindowingOverJoin()
{ {

1
sql/src/test/java/org/apache/druid/sql/calcite/NotYetSupported.java
View File

@ -93,6 +93,7 @@ public @interface NotYetSupported
T_ALLTYPES_ISSUES(AssertionError.class, "(t_alltype|allTypsUniq|fewRowsAllData).parquet.*Verifier.verify"), T_ALLTYPES_ISSUES(AssertionError.class, "(t_alltype|allTypsUniq|fewRowsAllData).parquet.*Verifier.verify"),
RESULT_MISMATCH(AssertionError.class, "(assertResulEquals|AssertionError: column content mismatch)"), RESULT_MISMATCH(AssertionError.class, "(assertResulEquals|AssertionError: column content mismatch)"),
UNSUPPORTED_NULL_ORDERING(DruidException.class, "(A|DE)SCENDING ordering with NULLS (LAST|FIRST)"), UNSUPPORTED_NULL_ORDERING(DruidException.class, "(A|DE)SCENDING ordering with NULLS (LAST|FIRST)"),
WINDOW_OPERATOR_QUERY_ON_UNSUPPORTED_DATASOURCE(DruidException.class, "WindowOperatorQuery must run on top of a query or inline data source"),
UNION_WITH_COMPLEX_OPERAND(DruidException.class, "Only Table and Values are supported as inputs for Union"), UNION_WITH_COMPLEX_OPERAND(DruidException.class, "Only Table and Values are supported as inputs for Union"),
UNION_MORE_STRICT_ROWTYPE_CHECK(DruidException.class, "Row signature mismatch in Union inputs"), UNION_MORE_STRICT_ROWTYPE_CHECK(DruidException.class, "Row signature mismatch in Union inputs"),
JOIN_CONDITION_NOT_PUSHED_CONDITION(DruidException.class, "SQL requires a join with '.*' condition"), JOIN_CONDITION_NOT_PUSHED_CONDITION(DruidException.class, "SQL requires a join with '.*' condition"),