Apache/druid
1
0
Fork 0
mirror of https://github.com/apache/druid.git synced 2025-02-26 04:55:24 +00:00
Code Issues Packages Projects Releases Wiki Activity

add some comments about string interning

Browse Source
This commit is contained in:
Xavier Léauté 2014-08-26 17:15:24 -07:00
parent 73623467e7
commit d15cd8fde7
2 changed files with 9 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
processing/src/main/java/io/druid/segment/incremental/IncrementalIndex.java
View File

@ -673,6 +673,10 @@ public class IncrementalIndex implements Iterable<Row>
falseIdsReverse = biMap.inverse(); falseIdsReverse = biMap.inverse();
} }
/**
* Returns the interned String value to allow fast comparisons using `==` instead of `.equals()`
* @see io.druid.segment.incremental.IncrementalIndexStorageAdapter.EntryHolderValueMatcherFactory#makeValueMatcher(String, String)
*/
public String get(String value) public String get(String value)
{ {
return value == null ? null : poorMansInterning.get(value); return value == null ? null : poorMansInterning.get(value);

4
processing/src/main/java/io/druid/segment/incremental/IncrementalIndexStorageAdapter.java
View File

@ -525,6 +525,10 @@ public class IncrementalIndexStorageAdapter implements StorageAdapter
} }
for (String dimVal : dims[dimIndex]) { for (String dimVal : dims[dimIndex]) {
/**
* using == here instead of .equals() to speed up lookups made possible by
* {@link io.druid.segment.incremental.IncrementalIndex.DimDim#poorMansInterning}
*/
if (id == dimVal) { if (id == dimVal) {
return true; return true;
} }