mirror of https://github.com/apache/druid.git
Revert commit 55ebf0cfdf
which caused following regression it fails when we issue the SegmentMetadataQuery by setting {"bySegment" : true} in context with exception - java.lang.ClassCastException: io.druid.query.Result cannot be cast to io.druid.query.metadata.metadata.SegmentAnalysis at io.druid.query.metadata.SegmentMetadataQueryQueryToolChest$4.compare(SegmentMetadataQueryQueryToolChest.java:222) ~[druid-processing-0.7.3-SNAPSHOT.jar:0.7.3-SNAPSHOT] at com.google.common.collect.NullsFirstOrdering.compare(NullsFirstOrdering.java:44) ~[guava-16.0.1.jar:?] at com.metamx.common.guava.MergeIterator$1.compare(MergeIterator.java:46) ~[java-util-0.27.0.jar:?] at com.metamx.common.guava.MergeIterator$1.compare(MergeIterator.java:42) ~[java-util-0.27.0.jar:?] at java.util.PriorityQueue.siftUpUsingComparator(PriorityQueue.java:649) ~[?:1.7.0_80]
This commit is contained in:
parent
fae86e83ad
commit
da0cc32bc8
|
@ -216,7 +216,7 @@ public class SegmentMetadataQueryQueryToolChest extends QueryToolChest<SegmentAn
|
||||||
};
|
};
|
||||||
}
|
}
|
||||||
|
|
||||||
public Ordering<SegmentAnalysis> getOrdering()
|
private Ordering<SegmentAnalysis> getOrdering()
|
||||||
{
|
{
|
||||||
return new Ordering<SegmentAnalysis>()
|
return new Ordering<SegmentAnalysis>()
|
||||||
{
|
{
|
||||||
|
|
|
@ -17,13 +17,20 @@
|
||||||
|
|
||||||
package io.druid.query.metadata;
|
package io.druid.query.metadata;
|
||||||
|
|
||||||
|
import com.google.common.base.Function;
|
||||||
|
import com.google.common.base.Throwables;
|
||||||
import com.google.common.collect.Maps;
|
import com.google.common.collect.Maps;
|
||||||
|
import com.google.common.util.concurrent.ListenableFuture;
|
||||||
|
import com.google.common.util.concurrent.ListeningExecutorService;
|
||||||
|
import com.google.common.util.concurrent.MoreExecutors;
|
||||||
import com.google.inject.Inject;
|
import com.google.inject.Inject;
|
||||||
import com.metamx.common.guava.Sequence;
|
import com.metamx.common.guava.Sequence;
|
||||||
import com.metamx.common.guava.Sequences;
|
import com.metamx.common.guava.Sequences;
|
||||||
import com.metamx.common.logger.Logger;
|
import com.metamx.common.logger.Logger;
|
||||||
import io.druid.query.ChainedExecutionQueryRunner;
|
import io.druid.query.AbstractPrioritizedCallable;
|
||||||
|
import io.druid.query.ConcatQueryRunner;
|
||||||
import io.druid.query.Query;
|
import io.druid.query.Query;
|
||||||
|
import io.druid.query.QueryInterruptedException;
|
||||||
import io.druid.query.QueryRunner;
|
import io.druid.query.QueryRunner;
|
||||||
import io.druid.query.QueryRunnerFactory;
|
import io.druid.query.QueryRunnerFactory;
|
||||||
import io.druid.query.QueryToolChest;
|
import io.druid.query.QueryToolChest;
|
||||||
|
@ -37,7 +44,11 @@ import io.druid.segment.Segment;
|
||||||
|
|
||||||
import java.util.Arrays;
|
import java.util.Arrays;
|
||||||
import java.util.Map;
|
import java.util.Map;
|
||||||
|
import java.util.concurrent.CancellationException;
|
||||||
|
import java.util.concurrent.ExecutionException;
|
||||||
import java.util.concurrent.ExecutorService;
|
import java.util.concurrent.ExecutorService;
|
||||||
|
import java.util.concurrent.TimeUnit;
|
||||||
|
import java.util.concurrent.TimeoutException;
|
||||||
|
|
||||||
public class SegmentMetadataQueryRunnerFactory implements QueryRunnerFactory<SegmentAnalysis, SegmentMetadataQuery>
|
public class SegmentMetadataQueryRunnerFactory implements QueryRunnerFactory<SegmentAnalysis, SegmentMetadataQuery>
|
||||||
{
|
{
|
||||||
|
@ -111,8 +122,60 @@ public class SegmentMetadataQueryRunnerFactory implements QueryRunnerFactory<Seg
|
||||||
ExecutorService exec, Iterable<QueryRunner<SegmentAnalysis>> queryRunners
|
ExecutorService exec, Iterable<QueryRunner<SegmentAnalysis>> queryRunners
|
||||||
)
|
)
|
||||||
{
|
{
|
||||||
return new ChainedExecutionQueryRunner<>(
|
final ListeningExecutorService queryExecutor = MoreExecutors.listeningDecorator(exec);
|
||||||
exec, toolChest.getOrdering(), queryWatcher, queryRunners
|
return new ConcatQueryRunner<SegmentAnalysis>(
|
||||||
|
Sequences.map(
|
||||||
|
Sequences.simple(queryRunners),
|
||||||
|
new Function<QueryRunner<SegmentAnalysis>, QueryRunner<SegmentAnalysis>>()
|
||||||
|
{
|
||||||
|
@Override
|
||||||
|
public QueryRunner<SegmentAnalysis> apply(final QueryRunner<SegmentAnalysis> input)
|
||||||
|
{
|
||||||
|
return new QueryRunner<SegmentAnalysis>()
|
||||||
|
{
|
||||||
|
@Override
|
||||||
|
public Sequence<SegmentAnalysis> run(
|
||||||
|
final Query<SegmentAnalysis> query,
|
||||||
|
final Map<String, Object> responseContext
|
||||||
|
)
|
||||||
|
{
|
||||||
|
final int priority = query.getContextPriority(0);
|
||||||
|
ListenableFuture<Sequence<SegmentAnalysis>> future = queryExecutor.submit(
|
||||||
|
new AbstractPrioritizedCallable<Sequence<SegmentAnalysis>>(priority)
|
||||||
|
{
|
||||||
|
@Override
|
||||||
|
public Sequence<SegmentAnalysis> call() throws Exception
|
||||||
|
{
|
||||||
|
return input.run(query, responseContext);
|
||||||
|
}
|
||||||
|
}
|
||||||
|
);
|
||||||
|
try {
|
||||||
|
queryWatcher.registerQuery(query, future);
|
||||||
|
final Number timeout = query.getContextValue("timeout", (Number) null);
|
||||||
|
return timeout == null ? future.get() : future.get(timeout.longValue(), TimeUnit.MILLISECONDS);
|
||||||
|
}
|
||||||
|
catch (InterruptedException e) {
|
||||||
|
log.warn(e, "Query interrupted, cancelling pending results, query id [%s]", query.getId());
|
||||||
|
future.cancel(true);
|
||||||
|
throw new QueryInterruptedException("Query interrupted");
|
||||||
|
}
|
||||||
|
catch(CancellationException e) {
|
||||||
|
throw new QueryInterruptedException("Query cancelled");
|
||||||
|
}
|
||||||
|
catch(TimeoutException e) {
|
||||||
|
log.info("Query timeout, cancelling pending results for query id [%s]", query.getId());
|
||||||
|
future.cancel(true);
|
||||||
|
throw new QueryInterruptedException("Query timeout");
|
||||||
|
}
|
||||||
|
catch (ExecutionException e) {
|
||||||
|
throw Throwables.propagate(e.getCause());
|
||||||
|
}
|
||||||
|
}
|
||||||
|
};
|
||||||
|
}
|
||||||
|
}
|
||||||
|
)
|
||||||
);
|
);
|
||||||
}
|
}
|
||||||
|
|
||||||
|
|
Loading…
Reference in New Issue