Apache
/
druid
mirror of https://github.com/apache/druid.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Fix Hadoop Indexing CLI for versions JDK v9+ 

For JDK v9+ this job will fail as URLClassloader is no longer the default classloader. Additionally, with the introduction of the jmod system, the job failed to find the correct JDK-included modules because the new classloader constructed for the job didn't reference the system classloader. Adding ClassLoader.getSystemClassLoader() as the parent classloader fixes this.
This commit is contained in:
Jesse Tuglu 2024-12-16 09:09:34 -08:00
parent 12eed753f7
commit dec1188cce
1 changed files with 9 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
services/src/main/java/org/apache/druid/cli/CliHadoopIndexer.java
View File

@ -29,6 +29,7 @@ import org.apache.druid.guice.ExtensionsLoader;
import org.apache.druid.indexing.common.config.TaskConfig;
import org.apache.druid.indexing.common.task.Initialization;
import org.apache.druid.java.util.common.logger.Logger;
import org.apache.druid.utils.JvmUtils;
import java.io.File;
import java.lang.reflect.Method;
@ -39,6 +40,7 @@ import java.util.Arrays;
import java.util.List;
/**
*
*/
@Command(
name = "hadoop",
@ -55,12 +57,12 @@ public class CliHadoopIndexer implements Runnable
private String argumentSpec;
@Option(name = {"-c", "--coordinate", "hadoopDependencies"},
description = "extra dependencies to pull down (e.g. non-default hadoop coordinates or extra hadoop jars)")
description = "extra dependencies to pull down (e.g. non-default hadoop coordinates or extra hadoop jars)")
@SuppressWarnings("MismatchedQueryAndUpdateOfCollection")
private List<String> coordinates;
@Option(name = "--no-default-hadoop",
description = "don't pull down the default hadoop version")
description = "don't pull down the default hadoop version")
public boolean noDefaultHadoop;
@Inject
@ -84,9 +86,7 @@ public class CliHadoopIndexer implements Runnable
extensionURLs.addAll(Arrays.asList(extensionLoader.getURLs()));
}
final List<URL> nonHadoopURLs = Arrays.asList(
((URLClassLoader) CliHadoopIndexer.class.getClassLoader()).getURLs()
);
final List<URL> nonHadoopURLs = JvmUtils.systemClassPath();
final List<URL> driverURLs = new ArrayList<>(nonHadoopURLs);
// put hadoop dependencies last to avoid jets3t & apache.httpcore version conflicts
@ -95,7 +95,10 @@ public class CliHadoopIndexer implements Runnable
driverURLs.addAll(Arrays.asList(hadoopLoader.getURLs()));
}
final URLClassLoader loader = new URLClassLoader(driverURLs.toArray(new URL[0]), null);
final URLClassLoader loader = new URLClassLoader(
driverURLs.toArray(new URL[0]),
ClassLoader.getSystemClassLoader()
);
Thread.currentThread().setContextClassLoader(loader);
final List<URL> jobUrls = new ArrayList<>();