Apache
/
druid
mirror of https://github.com/apache/druid.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Adjust for empty MAX result.

This commit is contained in:
Gian Merlino 2024-10-10 21:53:49 -07:00
parent a94acebfa4
commit e111520271
1 changed files with 15 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
sql/src/test/java/org/apache/druid/sql/calcite/CalciteQueryTest.java
View File

@ -4231,6 +4231,20 @@ public class CalciteQueryTest extends BaseCalciteQueryTest
@Test
public void testGroupByNothingWithLiterallyFalseFilter()
{
// Result of MAX(cnt) when nothing matches the filter.
final Long emptyMaxResult;
if (testBuilder().config.isRunningMSQ() && NullHandling.replaceWithDefault()) {
// Standard SQL dictates an empty MAX should return NULL. Calcite is smart enough to know that this query can
// never match anything, and therefore the query should return COUNT(*) = 0, MAX(cnt) = NULL. However, when
// running with MSQ in replace-with-default mode, the null gets turned into a 0 because we actually run the
// inline datasource through the MSQ engine. This doesn't happen with native, where the null from Calcite's
// plan is returned as-is.
emptyMaxResult = 0L;
} else {
emptyMaxResult = null;
}
testQuery(
"SELECT COUNT(*), MAX(cnt) FROM druid.foo WHERE 1 = 0",
ImmutableList.of(
@ -4247,7 +4261,7 @@ public class CalciteQueryTest extends BaseCalciteQueryTest
.build()
),
ImmutableList.of(
new Object[]{0L, null}
new Object[]{0L, emptyMaxResult}
)
);
}